Browse Source

Xcode: Revert "Don't set INSTALL_PATH unless target is SHARED_LIBRARY"

The change in commit 61acaa12af (xcode: Don't set INSTALL_PATH unless
target is SHARED_LIBRARY, 2022-07-14, v3.25.0-rc1~291^2) breaks some
existing use cases.  Revert it pending further investigation.

Fixes: #24087
Issue: #15183
Brad King 3 years ago
parent
commit
8d5631f0d0
1 changed files with 3 additions and 3 deletions
  1. 3 3
      Source/cmGlobalXCodeGenerator.cxx

+ 3 - 3
Source/cmGlobalXCodeGenerator.cxx

@@ -2915,8 +2915,8 @@ void cmGlobalXCodeGenerator::CreateBuildSettings(cmGeneratorTarget* gtgt,
   }
 
   // Create the INSTALL_PATH attribute.
+  std::string install_name_dir;
   if (gtgt->GetType() == cmStateEnums::SHARED_LIBRARY) {
-    std::string install_name_dir;
     // Get the install_name directory for the build tree.
     install_name_dir = gtgt->GetInstallNameDirForBuildTree(configName);
     // Xcode doesn't create the correct install_name in some cases.
@@ -2938,9 +2938,9 @@ void cmGlobalXCodeGenerator::CreateBuildSettings(cmGeneratorTarget* gtgt,
       extraLinkOptions += " -install_name ";
       extraLinkOptions += XCodeEscapePath(install_name);
     }
-    buildSettings->AddAttribute("INSTALL_PATH",
-                                this->CreateString(install_name_dir));
   }
+  buildSettings->AddAttribute("INSTALL_PATH",
+                              this->CreateString(install_name_dir));
 
   // Create the LD_RUNPATH_SEARCH_PATHS
   cmComputeLinkInformation* pcli = gtgt->GetLinkInformation(configName);