Browse Source

Add deprecation warnings for policies CMP0143 and below

The OLD behaviors of all policies are deprecated, but only by
documentation.  Add an explicit deprecation diagnostic for policies
introduced in CMake 3.26 and below to encourage projects to port
away from setting policies to OLD.
Brad King 4 months ago
parent
commit
94ff184a63
2 changed files with 9 additions and 1 deletions
  1. 1 1
      Source/cmMakefile.cxx
  2. 8 0
      Tests/RunCMake/VSSolution/CMP0143-OLD-stderr.txt

+ 1 - 1
Source/cmMakefile.cxx

@@ -4077,7 +4077,7 @@ bool cmMakefile::SetPolicy(cmPolicies::PolicyID id,
   }
 
   // Deprecate old policies.
-  if (status == cmPolicies::OLD && id <= cmPolicies::CMP0142 &&
+  if (status == cmPolicies::OLD && id <= cmPolicies::CMP0143 &&
       !(this->GetCMakeInstance()->GetIsInTryCompile() &&
         (
           // Policies set by cmCoreTryCompile::TryCompileCode.

+ 8 - 0
Tests/RunCMake/VSSolution/CMP0143-OLD-stderr.txt

@@ -0,0 +1,8 @@
+^CMake Deprecation Warning at CMakeLists\.txt:[0-9]+ \(cmake_minimum_required\):
+  The OLD behavior for policy CMP0143 will be removed from a future version
+  of CMake\.
+
+  The cmake-policies\(7\) manual explains that the OLD behaviors of all
+  policies are deprecated and that a policy should be set to OLD only under
+  specific short-term circumstances\.  Projects should be ported to the NEW
+  behavior and not rely on setting a policy to OLD\.$