Parcourir la source

Merge topic 'refactor-compute'

616d8f02 cmGeneratorTarget: Rename method to match operation.
ec56d244 cmGlobalGenerator: Process evaluation files after target depends.
1e5349a5 cmGlobalGenerator: Access makefile from makefiles container.
Brad King il y a 10 ans
Parent
commit
9a6d7d2e54

+ 1 - 1
Source/cmGeneratorTarget.cxx

@@ -2554,7 +2554,7 @@ void cmGeneratorTarget::GetCompileDefinitions(std::vector<std::string> &list,
 }
 
 //----------------------------------------------------------------------------
-void cmGeneratorTarget::GenerateTargetManifest(
+void cmGeneratorTarget::ComputeTargetManifest(
                                               const std::string& config) const
 {
   if (this->Target->IsImported())

+ 1 - 1
Source/cmGeneratorTarget.h

@@ -251,7 +251,7 @@ public:
                                 const std::string& config) const;
 
   /** Add the target output files to the global generator manifest.  */
-  void GenerateTargetManifest(const std::string& config) const;
+  void ComputeTargetManifest(const std::string& config) const;
 
   /**
    * Trace through the source files in this target and add al source files

+ 4 - 5
Source/cmGlobalGenerator.cxx

@@ -1325,11 +1325,9 @@ void cmGlobalGenerator::Generate()
   // Compute the manifest of main targets generated.
   for (i = 0; i < this->LocalGenerators.size(); ++i)
     {
-    this->LocalGenerators[i]->GenerateTargetManifest();
+    this->LocalGenerators[i]->ComputeTargetManifest();
     }
 
-  this->ProcessEvaluationFiles();
-
   // Compute the inter-target dependencies.
   if(!this->ComputeTargetDepends())
     {
@@ -1340,6 +1338,8 @@ void cmGlobalGenerator::Generate()
   // it builds by default.
   this->InitializeProgressMarks();
 
+  this->ProcessEvaluationFiles();
+
   for (i = 0; i < this->LocalGenerators.size(); ++i)
     {
     this->LocalGenerators[i]->ComputeHomeRelativeOutputPath();
@@ -1668,8 +1668,7 @@ void cmGlobalGenerator::CheckTargetProperties()
           text += "\n    linked by target \"";
           text += l->second.GetName();
           text += "\" in directory ";
-          text+=this->LocalGenerators[i]->GetMakefile()
-                    ->GetCurrentSourceDirectory();
+          text+=this->Makefiles[i]->GetCurrentSourceDirectory();
           notFoundMap[varName] = text;
           }
         }

+ 2 - 2
Source/cmLocalGenerator.cxx

@@ -447,7 +447,7 @@ void cmLocalGenerator::GenerateInstallRules()
 }
 
 //----------------------------------------------------------------------------
-void cmLocalGenerator::GenerateTargetManifest()
+void cmLocalGenerator::ComputeTargetManifest()
 {
   // Collect the set of configuration types.
   std::vector<std::string> configNames;
@@ -475,7 +475,7 @@ void cmLocalGenerator::GenerateTargetManifest()
         ci != configNames.end(); ++ci)
       {
       const char* config = ci->c_str();
-      target.GenerateTargetManifest(config);
+      target.ComputeTargetManifest(config);
       }
     }
 }

+ 1 - 1
Source/cmLocalGenerator.h

@@ -66,7 +66,7 @@ public:
   /**
    * Generate a manifest of target files that will be built.
    */
-  void GenerateTargetManifest();
+  void ComputeTargetManifest();
 
   ///! Get the makefile for this generator
   cmMakefile *GetMakefile() {