Browse Source

Merge topic 'ci-typos' into release-4.0

ddebf4653d ci: Do not check commit messages with 'typos' due to false positives

Acked-by: Kitware Robot <[email protected]>
Merge-request: !10306
Brad King 8 months ago
parent
commit
9b57b874d6
1 changed files with 3 additions and 6 deletions
  1. 3 6
      .gitlab/ci/typos.bash

+ 3 - 6
.gitlab/ci/typos.bash

@@ -7,11 +7,8 @@ result=0
 echo "Running 'typos' on source code..."
 typos || result=1
 
-if [ -n "$CI_MERGE_REQUEST_DIFF_BASE_SHA" ]; then
-  for COMMIT in $(git rev-list "^$CI_MERGE_REQUEST_DIFF_BASE_SHA" "$CI_COMMIT_SHA"); do
-    echo "Running 'typos' on commit message of $COMMIT..."
-    git show --format=%B -s "$COMMIT" | typos - || result=1
-  done
-fi
+# FIXME(typos): checking commit messages hits false positives
+# on "words" inside commit hashes.  We'd need a way to disable
+# checking of combined identifiers to avoid this.
 
 exit $result