STYLE: fix warnings: comparison signed/unsigned, unused variable

Alex

Source/cmInstallTargetGenerator.cxx

@@ -305,7 +305,7 @@ cmInstallTargetGenerator
 
   os << indent << "IF(EXISTS \"" << toDestDirPath << "\")\n";
   this->AddInstallNamePatchRule(os, indent.Next(), config, toDestDirPath);
-  this->AddChrpathPatchRule(os, indent.Next(), config, toDestDirPath);
+  this->AddChrpathPatchRule(os, indent.Next(), toDestDirPath);
   this->AddRanlibRule(os, indent.Next(), type, toDestDirPath);
   this->AddStripRule(os, indent.Next(), type, toDestDirPath);
   os << indent << "ENDIF(EXISTS \"" << toDestDirPath << "\")\n";
@@ -509,7 +509,7 @@ cmInstallTargetGenerator
 void
 cmInstallTargetGenerator
 ::AddChrpathPatchRule(std::ostream& os, Indent const& indent,
-                          const char* config, std::string const& toDestDirPath)
+                      std::string const& toDestDirPath)
 {
   if(this->ImportLibrary ||
      !(this->Target->GetType() == cmTarget::SHARED_LIBRARY ||

Source/cmInstallTargetGenerator.h

@@ -55,7 +55,7 @@ protected:
                                const char* config,
                                const std::string& toDestDirPath);
   void AddChrpathPatchRule(std::ostream& os, Indent const& indent,
-                         const char* config, std::string const& toDestDirPath);
+                           std::string const& toDestDirPath);
   
   void AddStripRule(std::ostream& os, Indent const& indent,
                     cmTarget::TargetType type,

Source/cmLocalGenerator.cxx

@@ -1480,7 +1480,7 @@ bool cmLocalGenerator::GetLinkerArgs(std::string& rpath,
                                      std::string& linkLibs,
                                      cmTarget& tgt,
                                      bool relink,
-                                     int minRpathSize)
+                                     unsigned int minRpathSize)
 {
   rpath = "";
   // collect all the flags needed for linking libraries
@@ -1658,16 +1658,14 @@ bool cmLocalGenerator::GetLinkerArgs(std::string& rpath,
       }
     }
 
-  if (rpath.size()<minRpathSize)
+  while (rpath.size() < minRpathSize)
     {
     if (rpath.size()==0)
       {
       rpath += runtimeFlag;
       }
-    while (rpath.size() < minRpathSize)
-      {
-      rpath += runtimeSep;
-      }
+
+    rpath += runtimeSep;
     }
   return true;
 }

Source/cmLocalGenerator.h

@@ -245,7 +245,7 @@ public:
   ///! Determine the arguments for the linker call, used also by 
   /// cmInstallTargetGenerator
   bool GetLinkerArgs(std::string& rpath, std::string& linkLibs,
-                     cmTarget& tgt, bool relink, int minRpathSize);
+                     cmTarget& tgt, bool relink, unsigned int minRpathSize);
   
   bool IsChrpathAvailable(const cmTarget& target);