Przeglądaj źródła

Fix issue #9395 - only return true for .exe files on Windows from the is_file_executable function. Makes behavior of this function conceptually consistent with Mac and Linux behavior. Thanks to Clinton Stimpson for the patch.

David Cole 16 lat temu
rodzic
commit
b5265c2475
1 zmienionych plików z 4 dodań i 4 usunięć
  1. 4 4
      Modules/GetPrerequisites.cmake

+ 4 - 4
Modules/GetPrerequisites.cmake

@@ -73,16 +73,16 @@ function(is_file_executable file result_var)
   get_filename_component(file_full "${file}" ABSOLUTE)
   string(TOLOWER "${file_full}" file_full_lower)
 
-  # If file name ends in .exe or .dll on Windows, *assume* executable:
+  # If file name ends in .exe on Windows, *assume* executable:
   #
   if(WIN32)
-    if("${file_full_lower}" MATCHES "\\.(exe|dll)$")
+    if("${file_full_lower}" MATCHES "\\.exe$")
       set(${result_var} 1 PARENT_SCOPE)
       return()
-    endif("${file_full_lower}" MATCHES "\\.(exe|dll)$")
+    endif("${file_full_lower}" MATCHES "\\.exe$")
 
     # A clause could be added here that uses output or return value of dumpbin
-    # to determine ${result_var}. In 99%+? practical cases, the exe|dll name
+    # to determine ${result_var}. In 99%+? practical cases, the exe name
     # match will be sufficient...
     #
   endif(WIN32)