Browse Source

cmCurl: Improve signature of cmCurlParseTLSVersion

Avoid requiring caller to allocate a string.
Brad King 1 year ago
parent
commit
cf4253ed60
2 changed files with 3 additions and 2 deletions
  1. 1 1
      Source/cmCurl.cxx
  2. 2 1
      Source/cmCurl.h

+ 1 - 1
Source/cmCurl.cxx

@@ -34,7 +34,7 @@
     }                                                                         \
   } while (false)
 
-cm::optional<int> cmCurlParseTLSVersion(std::string const& tls_version)
+cm::optional<int> cmCurlParseTLSVersion(cm::string_view tls_version)
 {
   cm::optional<int> v;
   if (tls_version == "1.0"_s) {

+ 2 - 1
Source/cmCurl.h

@@ -7,10 +7,11 @@
 #include <string>
 
 #include <cm/optional>
+#include <cm/string_view>
 
 #include <cm3p/curl/curl.h>
 
-cm::optional<int> cmCurlParseTLSVersion(std::string const& tls_version);
+cm::optional<int> cmCurlParseTLSVersion(cm::string_view tls_version);
 std::string cmCurlSetCAInfo(::CURL* curl, const std::string& cafile = {});
 std::string cmCurlSetNETRCOption(::CURL* curl, const std::string& netrc_level,
                                  const std::string& netrc_file);