Browse Source

Merge topic 'minor-cleanups'

80bda168 Simplify use of binary_search.
1927e4ba Remove const char string comparison helper.
Brad King 11 years ago
parent
commit
d8dde37d60
2 changed files with 1 additions and 9 deletions
  1. 1 3
      Source/cmGeneratorTarget.cxx
  2. 0 6
      Source/cmStandardIncludes.h

+ 1 - 3
Source/cmGeneratorTarget.cxx

@@ -519,9 +519,7 @@ bool cmGeneratorTarget::IsSystemIncludeDirectory(const std::string& dir,
     iter = this->SystemIncludesCache.insert(entry).first;
     }
 
-  std::string dirString = dir;
-  return std::binary_search(iter->second.begin(), iter->second.end(),
-                            dirString);
+  return std::binary_search(iter->second.begin(), iter->second.end(), dir);
 }
 
 //----------------------------------------------------------------------------

+ 0 - 6
Source/cmStandardIncludes.h

@@ -462,12 +462,6 @@ struct cmStrCmp {
     return strcmp(input, m_test.c_str()) == 0;
   }
 
-  // For use with binary_search
-  bool operator()(const char *str1, const char *str2) const
-  {
-    return strcmp(str1, str2) < 0;
-  }
-
 private:
   const std::string m_test;
 };