Explorar el Código

remove pointless return value from cmCTestTestHandler::CleanTestOutput()

Rolf Eike Beer hace 5 años
padre
commit
dc21177461
Se han modificado 2 ficheros con 3 adiciones y 4 borrados
  1. 2 3
      Source/CTest/cmCTestTestHandler.cxx
  2. 1 1
      Source/CTest/cmCTestTestHandler.h

+ 2 - 3
Source/CTest/cmCTestTestHandler.cxx

@@ -2089,11 +2089,11 @@ void cmCTestTestHandler::SetTestsToRunInformation(const char* in)
   }
 }
 
-bool cmCTestTestHandler::CleanTestOutput(std::string& output, size_t length)
+void cmCTestTestHandler::CleanTestOutput(std::string& output, size_t length)
 {
   if (!length || length >= output.size() ||
       output.find("CTEST_FULL_OUTPUT") != std::string::npos) {
-    return true;
+    return;
   }
 
   // Truncate at given length but do not break in the middle of a multi-byte
@@ -2124,7 +2124,6 @@ bool cmCTestTestHandler::CleanTestOutput(std::string& output, size_t length)
          "of "
       << length << " bytes.\n";
   output += msg.str();
-  return true;
 }
 
 bool cmCTestTestHandler::SetTestsProperties(

+ 1 - 1
Source/CTest/cmCTestTestHandler.h

@@ -235,7 +235,7 @@ protected:
   void AttachFiles(cmXMLWriter& xml, cmCTestTestResult& result);
 
   //! Clean test output to specified length
-  bool CleanTestOutput(std::string& output, size_t length);
+  void CleanTestOutput(std::string& output, size_t length);
 
   cmDuration ElapsedTestingTime;