Ver código fonte

cmake-gui: Fix use-after-free in Open-possible check

Fix `QCMake::checkOpenPossible` to copy `toLocal8Bit().data()` before
its lifetime expires.
Francisco Facioni 5 anos atrás
pai
commit
ecc0086bfc
1 arquivos alterados com 1 adições e 1 exclusões
  1. 1 1
      Source/QtDialog/QCMake.cxx

+ 1 - 1
Source/QtDialog/QCMake.cxx

@@ -486,7 +486,7 @@ void QCMake::setWarnUnusedMode(bool value)
 
 void QCMake::checkOpenPossible()
 {
-  auto data = this->BinaryDirectory.toLocal8Bit().data();
+  std::string data = this->BinaryDirectory.toLocal8Bit().data();
   auto possible = this->CMakeInstance->Open(data, true);
   emit openPossible(possible);
 }