浏览代码

Makefiles: Replace ternaries with if()s

Stephen Kelly 9 年之前
父节点
当前提交
ee49f006cf
共有 2 个文件被更改,包括 15 次插入10 次删除
  1. 7 6
      Source/cmLocalNinjaGenerator.cxx
  2. 8 4
      Source/cmLocalUnixMakefileGenerator3.cxx

+ 7 - 6
Source/cmLocalNinjaGenerator.cxx

@@ -486,12 +486,13 @@ std::string cmLocalNinjaGenerator::MakeCustomLauncher(
   std::string output;
   const std::vector<std::string>& outputs = ccg.GetOutputs();
   if (!outputs.empty()) {
-    cmOutputConverter::RelativeRoot relative_root =
-      ccg.GetWorkingDirectory().empty() ? cmOutputConverter::START_OUTPUT
-                                        : cmOutputConverter::NONE;
-
-    output =
-      this->Convert(outputs[0], relative_root, cmOutputConverter::SHELL);
+    if (ccg.GetWorkingDirectory().empty()) {
+      output = this->Convert(outputs[0], cmOutputConverter::START_OUTPUT,
+                             cmOutputConverter::SHELL);
+    } else {
+      output = this->Convert(outputs[0], cmOutputConverter::NONE,
+                             cmOutputConverter::SHELL);
+    }
   }
   vars.Output = output.c_str();
 

+ 8 - 4
Source/cmLocalUnixMakefileGenerator3.cxx

@@ -990,10 +990,14 @@ void cmLocalUnixMakefileGenerator3::AppendCustomCommand(
         std::string output;
         const std::vector<std::string>& outputs = ccg.GetOutputs();
         if (!outputs.empty()) {
-          output = this->Convert(outputs[0], workingDir.empty()
-                                   ? cmOutputConverter::START_OUTPUT
-                                   : cmOutputConverter::NONE,
-                                 cmOutputConverter::SHELL);
+          if (workingDir.empty()) {
+            output = this->Convert(outputs[0], cmOutputConverter::START_OUTPUT,
+                                   cmOutputConverter::SHELL);
+
+          } else {
+            output = this->Convert(outputs[0], cmOutputConverter::NONE,
+                                   cmOutputConverter::SHELL);
+          }
         }
         vars.Output = output.c_str();