Tests: Fix CMP0054 warnings

Hack the CMP0054 warning locally to be an error and run the test suite.
Resolve CMP0054 in Tests/* code as appropriate for each case.

Tests/CMakeOnly/MajorVersionSelection/CMakeLists.txt

@@ -20,13 +20,13 @@ endif ()
 
 string(TOUPPER "${MAJOR_TEST_MODULE}" MODULE_UPPER)
 
-if ( ( ${MAJOR_TEST_MODULE}_FOUND OR ${MODULE_UPPER}_FOUND ) AND "${VERSION_VAR}")
+if ( ( ${MAJOR_TEST_MODULE}_FOUND OR ${MODULE_UPPER}_FOUND ) AND ${VERSION_VAR})
   message(STATUS "${VERSION_VAR} is '${${VERSION_VAR}}'")
-  if ("${VERSION_VAR}" VERSION_LESS MAJOR_TEST_VERSION)
+  if (${VERSION_VAR} VERSION_LESS MAJOR_TEST_VERSION)
     message(SEND_ERROR "Found version ${${VERSION_VAR}} is less than requested major version ${MAJOR_TEST_VERSION}")
   endif ()
   math(EXPR V_PLUS_ONE "${MAJOR_TEST_VERSION} + 1")
-  if ("${VERSION_VAR}" VERSION_GREATER V_PLUS_ONE)
+  if (${VERSION_VAR} VERSION_GREATER V_PLUS_ONE)
     message(SEND_ERROR "Found version ${${VERSION_VAR}} is greater than requested major version ${MAJOR_TEST_VERSION}")
   endif ()
 endif ()

Tests/FunctionTest/CMakeLists.txt

@@ -92,7 +92,7 @@ endfunction()
 
 STRANGE_FUNCTION(var)
 set(second_var "second_var")
-if("${var}" STREQUAL "strange_function" AND "${second_var}" STREQUAL "second_var")
+if("x${var}" STREQUAL "xstrange_function" AND "x${second_var}" STREQUAL "xsecond_var")
   PASS("Case Test" "(${var} ${second_var})")
 else()
   FAILED("Case test" "(${var} ${second_var})")

Tests/MacroTest/CMakeLists.txt

@@ -36,7 +36,7 @@ macro(strange_macro m)
 endmacro()
 STRANGE_MACRO(var)
 set(second_var "second_var")
-if("${var}" STREQUAL "strange_macro" AND "${second_var}" STREQUAL "second_var")
+if("x${var}" STREQUAL "xstrange_macro" AND "x${second_var}" STREQUAL "xsecond_var")
   PASS("Case Test" "(${var} ${second_var})")
 else()
   FAILED("Case test" "(${var} ${second_var})")

Tests/RunCMake/FindPkgConfig/FindPkgConfig_NO_PKGCONFIG_PATH.cmake

@@ -26,7 +26,7 @@ endif()
 
 pkg_check_modules(FOO "${expected_path}")
 
-if(NOT "FOO_FOUND")
+if(NOT FOO_FOUND)
   message(FATAL_ERROR "Expected PKG_CONFIG_PATH: \"${expected_path}\".")
 endif()
 
@@ -36,6 +36,6 @@ set(PKG_CONFIG_USE_CMAKE_PREFIX_PATH TRUE)
 
 pkg_check_modules(BAR "${expected_path}" NO_CMAKE_PATH NO_CMAKE_ENVIRONMENT_PATH)
 
-if(NOT "BAR_FOUND")
+if(NOT BAR_FOUND)
   message(FATAL_ERROR "Expected PKG_CONFIG_PATH: \"${expected_path}\".")
 endif()

Tests/RunCMake/FindPkgConfig/FindPkgConfig_PKGCONFIG_PATH.cmake

@@ -46,6 +46,6 @@ endif()
 
 pkg_check_modules(FOO "${expected_path}")
 
-if(NOT "FOO_FOUND")
+if(NOT FOO_FOUND)
   message(FATAL_ERROR "Expected PKG_CONFIG_PATH: \"${expected_path}\".")
 endif()

Tests/RunCMake/FindPkgConfig/FindPkgConfig_PKGCONFIG_PATH_NO_CMAKE_ENVIRONMENT_PATH.cmake

@@ -46,6 +46,6 @@ endif()
 
 pkg_check_modules(FOO "${expected_path}" NO_CMAKE_ENVIRONMENT_PATH)
 
-if(NOT "FOO_FOUND")
+if(NOT FOO_FOUND)
   message(FATAL_ERROR "Expected PKG_CONFIG_PATH: \"${expected_path}\".")
 endif()

Tests/RunCMake/FindPkgConfig/FindPkgConfig_PKGCONFIG_PATH_NO_CMAKE_PATH.cmake

@@ -46,6 +46,6 @@ endif()
 
 pkg_check_modules(FOO "${expected_path}" NO_CMAKE_PATH)
 
-if(NOT "FOO_FOUND")
+if(NOT FOO_FOUND)
   message(FATAL_ERROR "Expected PKG_CONFIG_PATH: \"${expected_path}\".")
 endif()

Tests/StringFileTest/CMakeLists.txt

@@ -123,7 +123,7 @@ string(STRIP "ST2 " ST2)
 string(STRIP "  ST3" ST3)
 
 foreach(var ST1 ST2 ST3)
-  if("${var}" STREQUAL "${${var}}")
+  if("x${var}" STREQUAL "x${${var}}")
     message("[${var}] == [${${var}}]")
   else()
     message(SEND_ERROR "Problem with the STRIP command for ${var}: [${${var}}]")