Ver Fonte

Merge topic 'commit-ref-in-prose'

939dc9a58c Help: prefer commit hashes in commit references

Acked-by: Kitware Robot <[email protected]>
Merge-request: !2854
Brad King há 6 anos atrás
pai
commit
fc96aa03f8
1 ficheiros alterados com 14 adições e 5 exclusões
  1. 14 5
      Help/dev/review.rst

+ 14 - 5
Help/dev/review.rst

@@ -238,12 +238,10 @@ Referencing Commits in Commit Messages
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 
 The preferred form for references to other commits is
 The preferred form for references to other commits is
-``commit <commit> (<subject>, <date>)``, where:
+``commit <shorthash> (<subject>, <date>)``, where:
 
 
-* ``<commit>``:
-  If available, a tag-relative name of the commit produced by
-  ``git describe --contains <commit-ish>``.  Otherwise, the first
-  8-10 characters of the commit ``<hash>``.
+* ``<shorthash>``:
+  The abbreviated hash of the commit.
 
 
 * ``<subject>``:
 * ``<subject>``:
   The first line of the commit message.
   The first line of the commit message.
@@ -252,6 +250,17 @@ The preferred form for references to other commits is
   The author date of the commit, in its original time zone, formatted as
   The author date of the commit, in its original time zone, formatted as
   ``CCYY-MM-DD``.  ``git-log(1)`` shows the original time zone by default.
   ``CCYY-MM-DD``.  ``git-log(1)`` shows the original time zone by default.
 
 
+This may be generated with
+``git show -s --date=short --pretty="format:%h (%s, %ad)" <commit>``.
+
+If the commit is a fix for the mentioned commit, consider using a ``Fixes:``
+trailer in the commit message with the specified format. This trailer should
+not be word-wrapped. Note that if there is also an issue for what is being
+fixed, it is preferrable to link to the issue instead.
+
+If relevant, add the first release tag of CMake containing the commit after
+the ``<date>``, i.e., ``commit <shorthash> (<subject>, <date>, <tag>)``.
+
 Alternatively, the full commit ``<hash>`` may be used.
 Alternatively, the full commit ``<hash>`` may be used.
 
 
 Revising Commit Messages
 Revising Commit Messages