Prechádzať zdrojové kódy

cppcheck issues:

[src/Cedar/SM.c:875] -> [src/Cedar/SM.c:882]: (warning) Either the condition 'd==0' is redundant or there is possible null pointer dereference: d.
[src/Cedar/UdpAccel.c:119] -> [src/Cedar/UdpAccel.c:123]: (warning) Either the condition 'a==0' is redundant or there is possible null pointer dereference: a.
Ilya Shipitsin 9 rokov pred
rodič
commit
01edd34bbe
2 zmenil súbory, kde vykonal 2 pridanie a 2 odobranie
  1. 1 1
      src/Cedar/SM.c
  2. 1 1
      src/Cedar/UdpAccel.c

+ 1 - 1
src/Cedar/SM.c

@@ -872,7 +872,6 @@ UINT SmDDnsDlg(HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam, void *param)
 
 // Get the ddns key from the server configuration file
 static UINT SmDdnsGetKey(char *key, SM_DDNS *d){
-	RPC *rpc = d->s->Rpc;
 	RPC_CONFIG config;
 	UINT err;
 	BUF *buf;
@@ -882,6 +881,7 @@ static UINT SmDdnsGetKey(char *key, SM_DDNS *d){
 	if(d == NULL || d->s == NULL || key == NULL){
 		return ERR_INTERNAL_ERROR;
 	}
+	RPC *rpc = d->s->Rpc;
 
 	Zero(&config, sizeof(config));
 	err = ScGetConfig(d->s->Rpc, &config);

+ 1 - 1
src/Cedar/UdpAccel.c

@@ -116,7 +116,6 @@
 // Polling process
 void UdpAccelPoll(UDP_ACCEL *a)
 {
-	UCHAR *tmp = a->TmpBuf;
 	IP nat_t_ip;
 	UINT num_ignore_errors = 0;
 	// Validate arguments
@@ -124,6 +123,7 @@ void UdpAccelPoll(UDP_ACCEL *a)
 	{
 		return;
 	}
+	UCHAR *tmp = a->TmpBuf;
 
 	Lock(a->NatT_Lock);
 	{