Browse Source

fix: Replace "math/rand" with "crypto/rand" in padding generation(#2032) (#1337)

Co-authored-by: NaLan ZeYu <[email protected]>
degfw 3 years ago
parent
commit
d3efd2d24f
1 changed files with 3 additions and 2 deletions
  1. 3 2
      common/crypto/auth.go

+ 3 - 2
common/crypto/auth.go

@@ -2,8 +2,8 @@ package crypto
 
 import (
 	"crypto/cipher"
+	"crypto/rand"
 	"io"
-	"math/rand"
 
 	"github.com/xtls/xray-core/common"
 	"github.com/xtls/xray-core/common/buf"
@@ -265,7 +265,8 @@ func (w *AuthenticationWriter) seal(b []byte) (*buf.Buffer, error) {
 		return nil, err
 	}
 	if paddingSize > 0 {
-		// With size of the chunk and padding length encrypted, the content of padding doesn't matter much.
+		// These paddings will send in clear text.
+		// To avoid leakage of PRNG internal state, a cryptographically secure PRNG should be used.
 		paddingBytes := eb.Extend(paddingSize)
 		common.Must2(rand.Read(paddingBytes))
 	}