Rename TransportMessage internal persistence helpers and add comments

src/Abc.Zebus.Persistence.Tests/Handlers/PersistMessageCommandHandlerTests.cs

@@ -115,7 +115,7 @@ namespace Abc.Zebus.Persistence.Tests.Handlers
                                .Returns<PeerId>(peerId => replayers[peerId]);
 
             var sourceMessage = new FakeCommand(123456);
-            var sourceTransportMessage = sourceMessage.ToTransportMessage().ToPersistTransportMessage(targetPeerIds);
+            var sourceTransportMessage = sourceMessage.ToTransportMessage().ConvertToPersistTransportMessage(targetPeerIds);
             var persistMessageCommand = (PersistMessageCommand)sourceTransportMessage.ToMessage();
 
             // Act

src/Abc.Zebus.Testing/TestExtensions.cs

@@ -29,7 +29,7 @@ namespace Abc.Zebus.Testing
 
         public static TransportMessage ToPersistTransportMessage(this TransportMessage transportMessage, params PeerId[] peerIds)
         {
-            return transportMessage.ToPersistTransportMessage(peerIds.ToList());
+            return transportMessage.ConvertToPersistTransportMessage(peerIds.ToList());
         }
 
         public static IMessage? ToMessage(this TransportMessage transportMessage)

src/Abc.Zebus/Serialization/MessageSerializerExtensions.cs

@@ -29,9 +29,9 @@ namespace Abc.Zebus.Serialization
         }
 
         private static TransportMessage ToTransportMessage(PersistMessageCommand persistMessageCommand)
-            => persistMessageCommand.TransportMessage.ToPersistTransportMessage(persistMessageCommand.Targets);
+            => persistMessageCommand.TransportMessage.ConvertToPersistTransportMessage(persistMessageCommand.Targets);
 
         private static IMessage ToPersistMessageCommand(TransportMessage transportMessage)
-            => new PersistMessageCommand(transportMessage.UnpackPersistTransportMessage(), transportMessage.PersistentPeerIds!);
+            => new PersistMessageCommand(transportMessage.ConvertFromPersistTransportMessage(), transportMessage.PersistentPeerIds!);
     }
 }

src/Abc.Zebus/Transport/TransportMessage.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using Abc.Zebus.Persistence;
 using Abc.Zebus.Serialization.Protobuf;
 using JetBrains.Annotations;
 using Newtonsoft.Json;
@@ -91,8 +92,16 @@ namespace Abc.Zebus.Transport
             return Content.ToArray();
         }
 
-        internal TransportMessage ToPersistTransportMessage(List<PeerId> peerIds) => new TransportMessage(Id, MessageTypeId, Content, Originator, Environment, WasPersisted, peerIds);
-        internal TransportMessage UnpackPersistTransportMessage() => new TransportMessage(Id, MessageTypeId, Content, Originator, Environment, WasPersisted, null);
+        /// <summary>
+        /// Gets a <see cref="TransportMessage"/> that represents a <see cref="PersistMessageCommand"/> that wraps the current transport message.
+        /// </summary>
+        internal TransportMessage ConvertToPersistTransportMessage(List<PeerId> peerIds) => new TransportMessage(Id, MessageTypeId, Content, Originator, Environment, WasPersisted, peerIds);
+
+        /// <summary>
+        /// Gets back the wrapped transport message that is inside a <see cref="PersistMessageCommand"/>.
+        /// </summary>
+        /// <returns></returns>
+        internal TransportMessage ConvertFromPersistTransportMessage() => new TransportMessage(Id, MessageTypeId, Content, Originator, Environment, WasPersisted, null);
 
         public static byte[] Serialize(TransportMessage transportMessage)
         {