Browse Source

Do not restrict `docker inspect` to 1 arg, can be zero (inspect current context), one or several.
Especially, inspect with zero param is already used by VSCode. Cf https://github.com/docker/desktop-microsoft/issues/19

Guillaume Tardif 5 years ago
parent
commit
1bb2909d1a
2 changed files with 8 additions and 1 deletions
  1. 3 1
      cli/cmd/context/inspect.go
  2. 5 0
      tests/e2e/e2e_test.go

+ 3 - 1
cli/cmd/context/inspect.go

@@ -37,10 +37,12 @@ func inspectCommand() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "inspect",
 		Short: "Display detailed information on one or more contexts",
-		Args:  cobra.ExactArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			return mobycli.ExecCmd(cmd)
 		},
 	}
+	// flags matching delegated command in moby cli
+	flags := cmd.Flags()
+	flags.StringP("format", "f", "", "Format the output using the given Go template")
 	return cmd
 }

+ 5 - 0
tests/e2e/e2e_test.go

@@ -79,6 +79,11 @@ func (s *E2eSuite) TestInspectDefaultContext() {
 	Expect(output).To(ContainSubstring(`"Name": "default"`))
 }
 
+func (s *E2eSuite) TestInspectContextNoArgs() {
+	output := s.NewDockerCommand("context", "inspect").ExecOrDie()
+	Expect(output).To(ContainSubstring(`"Name": "default"`))
+}
+
 func (s *E2eSuite) TestContextCreateParseErrorDoesNotDelegateToLegacy() {
 	It("should dispay new cli error when parsing context create flags", func() {
 		_, err := s.NewDockerCommand("context", "create", "aci", "--subscription-id", "titi").Exec()