Bladeren bron

Reject compose file not setting service image

Signed-off-by: Nicolas De Loof <[email protected]>
Nicolas De Loof 5 jaren geleden
bovenliggende
commit
242216cab1
2 gewijzigde bestanden met toevoegingen van 5 en 0 verwijderingen
  1. 1 0
      ecs/pkg/amazon/backend/cloudformation.go
  2. 4 0
      ecs/pkg/amazon/backend/convert.go

+ 1 - 0
ecs/pkg/amazon/backend/cloudformation.go

@@ -40,6 +40,7 @@ func (c *FargateCompatibilityChecker) CheckPortsPublished(p *types.ServicePortCo
 	}
 	if p.Published != p.Target {
 		c.Error("published port can't be set to a distinct value than container port")
+		p.Published = p.Target
 	}
 }
 

+ 4 - 0
ecs/pkg/amazon/backend/convert.go

@@ -17,6 +17,10 @@ import (
 )
 
 func Convert(project *types.Project, service types.ServiceConfig) (*ecs.TaskDefinition, error) {
+	if service.Image == "" {
+		return nil, fmt.Errorf("service %s doesn't define a Docker image to run", service.Name)
+	}
+
 	cpu, mem, err := toLimits(service)
 	if err != nil {
 		return nil, err