1
0
Эх сурвалжийг харах

Merge pull request #876 from docker/ecs_pin_secret_sidecar

Pin ECS secrets sidecar image & add makefile targets
Guillaume Tardif 5 жил өмнө
parent
commit
4b88896547
2 өөрчлөгдсөн 7 нэмэгдсэн , 1 устгасан
  1. 6 0
      Makefile
  2. 1 1
      ecs/convert.go

+ 6 - 0
Makefile

@@ -110,6 +110,12 @@ build-ecs-search-sidecar:  ## build ecs search sidecar image locally and tag it
 publish-ecs-search-sidecar: build-ecs-search-sidecar ## build & publish ecs search sidecar image with make publish-ecs-search-sidecar tag=0.1
 	docker pull docker/ecs-searchdomain-sidecar:$(tag) && echo "Failure: Tag already exists" || docker push docker/ecs-searchdomain-sidecar:$(tag)
 
+build-ecs-secrets-sidecar:  ## build ecs secrets sidecar image locally and tag it with make build-ecs-secrets-sidecar tag=0.1
+	docker build -t docker/ecs-secrets-sidecar:$(tag) ecs/secrets
+
+publish-ecs-secrets-sidecar: build-ecs-secrets-sidecar ## build & publish ecs secrets sidecar image with make publish-ecs-secrets-sidecar tag=0.1
+	docker pull docker/ecs-secrets-sidecar:$(tag) && echo "Failure: Tag already exists" || docker push docker/ecs-secrets-sidecar:$(tag)
+
 clean-aci-e2e: ## Make sure no ACI tests are currently runnnig in the CI when invoking this. Delete ACI E2E tests resources that might have leaked when ctrl-C E2E tests.
 	@ echo "Will delete resource groups: "
 	@ az group list | jq '.[].name' | grep -i E2E-Test

+ 1 - 1
ecs/convert.go

@@ -36,7 +36,7 @@ import (
 	"github.com/joho/godotenv"
 )
 
-const secretsInitContainerImage = "docker/ecs-secrets-sidecar"
+const secretsInitContainerImage = "docker/ecs-secrets-sidecar:1.0"
 const searchDomainInitContainerImage = "docker/ecs-searchdomain-sidecar:1.0"
 
 func (b *ecsAPIService) createTaskDefinition(project *types.Project, service types.ServiceConfig, resources awsResources) (*ecs.TaskDefinition, error) {