浏览代码

Merge pull request #1570 from aanand/fix-build-pull

Explicitly set pull=False when building
Aanand Prasad 10 年之前
父节点
当前提交
4f83a18912
共有 2 个文件被更改,包括 12 次插入0 次删除
  1. 1 0
      compose/service.py
  2. 11 0
      tests/unit/service_test.py

+ 1 - 0
compose/service.py

@@ -612,6 +612,7 @@ class Service(object):
             tag=self.image_name,
             stream=True,
             rm=True,
+            pull=False,
             nocache=no_cache,
             dockerfile=self.options.get('dockerfile', None),
         )

+ 11 - 0
tests/unit/service_test.py

@@ -312,6 +312,17 @@ class ServiceTest(unittest.TestCase):
         with self.assertRaises(NeedsBuildError):
             service.create_container(do_build=False)
 
+    def test_build_does_not_pull(self):
+        self.mock_client.build.return_value = [
+            '{"stream": "Successfully built 12345"}',
+        ]
+
+        service = Service('foo', client=self.mock_client, build='.')
+        service.build()
+
+        self.assertEqual(self.mock_client.build.call_count, 1)
+        self.assertFalse(self.mock_client.build.call_args[1]['pull'])
+
 
 class ServiceVolumesTest(unittest.TestCase):