Browse Source

Revert "Add 'labels:' config option"

This reverts commit 721327110d922f807a225a572d772168c8c22641.

Signed-off-by: Aanand Prasad <[email protected]>
Aanand Prasad 10 years ago
parent
commit
965426e39b
6 changed files with 3 additions and 75 deletions
  1. 1 1
      compose/cli/docker_client.py
  2. 0 27
      compose/config.py
  3. 1 1
      docs/install.md
  4. 0 18
      docs/yml.md
  5. 1 1
      requirements.txt
  6. 0 27
      tests/integration/service_test.py

+ 1 - 1
compose/cli/docker_client.py

@@ -32,4 +32,4 @@ def docker_client():
         )
         )
 
 
     timeout = int(os.environ.get('DOCKER_CLIENT_TIMEOUT', 60))
     timeout = int(os.environ.get('DOCKER_CLIENT_TIMEOUT', 60))
-    return Client(base_url=base_url, tls=tls_config, version='1.18', timeout=timeout)
+    return Client(base_url=base_url, tls=tls_config, version='1.15', timeout=timeout)

+ 0 - 27
compose/config.py

@@ -17,7 +17,6 @@ DOCKER_CONFIG_KEYS = [
     'environment',
     'environment',
     'hostname',
     'hostname',
     'image',
     'image',
-    'labels',
     'links',
     'links',
     'mem_limit',
     'mem_limit',
     'net',
     'net',
@@ -172,9 +171,6 @@ def process_container_options(service_dict, working_dir=None):
     if 'volumes' in service_dict:
     if 'volumes' in service_dict:
         service_dict['volumes'] = resolve_host_paths(service_dict['volumes'], working_dir=working_dir)
         service_dict['volumes'] = resolve_host_paths(service_dict['volumes'], working_dir=working_dir)
 
 
-    if 'labels' in service_dict:
-        service_dict['labels'] = parse_labels(service_dict['labels'])
-
     return service_dict
     return service_dict
 
 
 
 
@@ -336,29 +332,6 @@ def volumes_from_dict(d):
     return ["%s:%s" % (host_path, container_path) for (container_path, host_path) in d.items()]
     return ["%s:%s" % (host_path, container_path) for (container_path, host_path) in d.items()]
 
 
 
 
-def parse_labels(labels):
-    if not labels:
-        return {}
-
-    if isinstance(labels, list):
-        return dict(split_label(e) for e in labels)
-
-    if isinstance(labels, dict):
-        return labels
-
-    raise ConfigurationError(
-        "labels \"%s\" must be a list or mapping" %
-        labels
-    )
-
-
-def split_label(label):
-    if '=' in label:
-        return label.split('=', 1)
-    else:
-        return label, ''
-
-
 def expand_path(working_dir, path):
 def expand_path(working_dir, path):
     return os.path.abspath(os.path.join(working_dir, path))
     return os.path.abspath(os.path.join(working_dir, path))
 
 

+ 1 - 1
docs/install.md

@@ -10,7 +10,7 @@ Compose with a `curl` command.
 
 
 ### Install Docker
 ### Install Docker
 
 
-First, install Docker version 1.6 or greater:
+First, install Docker version 1.3 or greater:
 
 
 - [Instructions for Mac OS X](http://docs.docker.com/installation/mac/)
 - [Instructions for Mac OS X](http://docs.docker.com/installation/mac/)
 - [Instructions for Ubuntu](http://docs.docker.com/installation/ubuntulinux/)
 - [Instructions for Ubuntu](http://docs.docker.com/installation/ubuntulinux/)

+ 0 - 18
docs/yml.md

@@ -253,24 +253,6 @@ db:
 > configuration options are **not** inherited - you will have to define
 > configuration options are **not** inherited - you will have to define
 > those manually each time you extend it.
 > those manually each time you extend it.
 
 
-### labels
-
-Add metadata to containers using [Docker labels](http://docs.docker.com/userguide/labels-custom-metadata/). You can use either an array or a dictionary.
-
-It's recommended that you use reverse-DNS notation to prevent your labels from conflicting with those used by other software.
-
-```
-labels:
-  com.example.description: "Accounting webapp"
-  com.example.department: "Finance"
-  com.example.label-with-empty-value: ""
-
-labels:
-  - "com.example.description=Accounting webapp"
-  - "com.example.department=Finance"
-  - "com.example.label-with-empty-value"
-```
-
 ### net
 ### net
 
 
 Networking mode. Use the same values as the docker client `--net` parameter.
 Networking mode. Use the same values as the docker client `--net` parameter.

+ 1 - 1
requirements.txt

@@ -1,5 +1,5 @@
 PyYAML==3.10
 PyYAML==3.10
--e git+https://github.com/docker/docker-py.git@70ce156e26d283d181e6ec10bd1309ddc1da1bbd#egg=docker-py
+docker-py==1.1.0
 dockerpty==0.3.2
 dockerpty==0.3.2
 docopt==0.6.1
 docopt==0.6.1
 requests==2.5.3
 requests==2.5.3

+ 0 - 27
tests/integration/service_test.py

@@ -491,30 +491,3 @@ class ServiceTest(DockerClientTestCase):
         env = create_and_start_container(service).environment
         env = create_and_start_container(service).environment
         for k,v in {'FILE_DEF': 'F1', 'FILE_DEF_EMPTY': '', 'ENV_DEF': 'E3', 'NO_DEF': ''}.items():
         for k,v in {'FILE_DEF': 'F1', 'FILE_DEF_EMPTY': '', 'ENV_DEF': 'E3', 'NO_DEF': ''}.items():
             self.assertEqual(env[k], v)
             self.assertEqual(env[k], v)
-
-    def test_labels(self):
-        labels_dict = {
-            'com.example.description': "Accounting webapp",
-            'com.example.department': "Finance",
-            'com.example.label-with-empty-value': "",
-        }
-
-        service = self.create_service('web', labels=labels_dict)
-        labels = create_and_start_container(service).get('Config.Labels').items()
-        for pair in labels_dict.items():
-            self.assertIn(pair, labels)
-
-        labels_list = ["%s=%s" % pair for pair in labels_dict.items()]
-
-        service = self.create_service('web', labels=labels_list)
-        labels = create_and_start_container(service).get('Config.Labels').items()
-        for pair in labels_dict.items():
-            self.assertIn(pair, labels)
-
-    def test_empty_labels(self):
-        labels_list = ['foo', 'bar']
-
-        service = self.create_service('web', labels=labels_list)
-        labels = create_and_start_container(service).get('Config.Labels').items()
-        for name in labels_list:
-            self.assertIn((name, ''), labels)