1
0
Эх сурвалжийг харах

Merge pull request #953 from docker/windows_e2e_docker_logout

On GH Actions windows nodes, ensure there is no automatic docker login before running ACI E2E tests
Guillaume Tardif 5 жил өмнө
parent
commit
97560f8ffc

+ 4 - 1
.github/workflows/optional-ci.yml

@@ -141,4 +141,7 @@ jobs:
           AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
           AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
           AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
           AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
           AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
           AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
-        run: make e2e-aci
+        # need to docker logout on windows nodes, it seems GHActions does a `docker login --user githubactions` specifically on windows nodes
+        run: |
+          docker logout
+          make e2e-aci