Browse Source

Don't overwrite existing dependency condition

(when service has `volumes_from` another service with dependency condition)

Signed-off-by: Laura Brehm <[email protected]>
Laura Brehm 3 năm trước cách đây
mục cha
commit
b564cc5a17
1 tập tin đã thay đổi với 2 bổ sung1 xóa
  1. 2 1
      pkg/compose/create.go

+ 2 - 1
pkg/compose/create.go

@@ -125,7 +125,8 @@ func prepareVolumes(p *types.Project) error {
 				p.Services[i].DependsOn = make(types.DependsOnConfig, len(dependServices))
 				p.Services[i].DependsOn = make(types.DependsOnConfig, len(dependServices))
 			}
 			}
 			for _, service := range p.Services {
 			for _, service := range p.Services {
-				if utils.StringContains(dependServices, service.Name) {
+				if utils.StringContains(dependServices, service.Name) &&
+					p.Services[i].DependsOn[service.Name].Condition == "" {
 					p.Services[i].DependsOn[service.Name] = types.ServiceDependency{
 					p.Services[i].DependsOn[service.Name] = types.ServiceDependency{
 						Condition: types.ServiceConditionStarted,
 						Condition: types.ServiceConditionStarted,
 					}
 					}