Переглянути джерело

Fix e2e tests using golden files on windows

guillaume.tardif 5 роки тому
батько
коміт
c73998bd2d

+ 2 - 2
tests/e2e/e2e_test.go

@@ -65,7 +65,7 @@ func (s *E2eSuite) TestContextDefault() {
 		output := s.NewDockerCommand("context", "show").ExecOrDie()
 		output := s.NewDockerCommand("context", "show").ExecOrDie()
 		Expect(output).To(ContainSubstring("default"))
 		Expect(output).To(ContainSubstring("default"))
 		output = s.NewCommand("docker", "context", "ls").ExecOrDie()
 		output = s.NewCommand("docker", "context", "ls").ExecOrDie()
-		golden.Assert(s.T(), output, "ls-out-default.golden")
+		golden.Assert(s.T(), output, GoldenFile("ls-out-default"))
 	})
 	})
 }
 }
 
 
@@ -187,7 +187,7 @@ func (s *E2eSuite) TestMockBackend() {
 		currentContext := s.NewDockerCommand("context", "use", "test-example").ExecOrDie()
 		currentContext := s.NewDockerCommand("context", "use", "test-example").ExecOrDie()
 		Expect(currentContext).To(ContainSubstring("test-example"))
 		Expect(currentContext).To(ContainSubstring("test-example"))
 		output := s.NewDockerCommand("context", "ls").ExecOrDie()
 		output := s.NewDockerCommand("context", "ls").ExecOrDie()
-		golden.Assert(s.T(), output, "ls-out-test-example.golden")
+		golden.Assert(s.T(), output, GoldenFile("ls-out-test-example"))
 		output = s.NewDockerCommand("context", "show").ExecOrDie()
 		output = s.NewDockerCommand("context", "show").ExecOrDie()
 		Expect(output).To(ContainSubstring("test-example"))
 		Expect(output).To(ContainSubstring("test-example"))
 	})
 	})

+ 2 - 0
tests/e2e/testdata/ls-out-default-windows.golden

@@ -0,0 +1,2 @@
+NAME                TYPE                DESCRIPTION                               DOCKER ENPOINT                   KUBERNETES ENDPOINT   ORCHESTRATOR
+default *           docker              Current DOCKER_HOST based configuration   npipe:////./pipe/docker_engine                         swarm

+ 3 - 0
tests/e2e/testdata/ls-out-test-example-windows.golden

@@ -0,0 +1,3 @@
+NAME                TYPE                DESCRIPTION                               DOCKER ENPOINT                   KUBERNETES ENDPOINT   ORCHESTRATOR
+default             docker              Current DOCKER_HOST based configuration   npipe:////./pipe/docker_engine                         swarm
+test-example *      example                                                                                                              

+ 8 - 0
tests/framework/helper.go

@@ -28,6 +28,7 @@
 package framework
 package framework
 
 
 import (
 import (
+	"runtime"
 	"strings"
 	"strings"
 
 
 	"github.com/robpike/filter"
 	"github.com/robpike/filter"
@@ -48,6 +49,13 @@ func Columns(line string) []string {
 	return filter.Choose(strings.Split(line, " "), nonEmptyString).([]string)
 	return filter.Choose(strings.Split(line, " "), nonEmptyString).([]string)
 }
 }
 
 
+func GoldenFile(name string) string {
+	if runtime.GOOS == "windows" {
+		return name + "-windows.golden"
+	}
+	return name + ".golden"
+}
+
 // It runs func
 // It runs func
 func It(description string, test func()) {
 func It(description string, test func()) {
 	test()
 	test()