Просмотр исходного кода

Allow _.- chars in service names

As VALID_CHARS is shared with project names, these chars are also
now allowed within project names.

Signed-off-by: Mazz Mosley <[email protected]>
Mazz Mosley 10 лет назад
Родитель
Сommit
f33f673b49
2 измененных файлов с 12 добавлено и 7 удалено
  1. 1 1
      compose/service.py
  2. 11 6
      tests/unit/service_test.py

+ 1 - 1
compose/service.py

@@ -47,7 +47,7 @@ DOCKER_START_KEYS = [
     'security_opt',
 ]
 
-VALID_NAME_CHARS = '[a-zA-Z0-9]'
+VALID_NAME_CHARS = '[a-zA-Z0-9\._\-]'
 
 
 class BuildError(Exception):

+ 11 - 6
tests/unit/service_test.py

@@ -34,18 +34,23 @@ class ServiceTest(unittest.TestCase):
         self.assertRaises(ConfigError, lambda: Service(name='/', image='foo'))
         self.assertRaises(ConfigError, lambda: Service(name='!', image='foo'))
         self.assertRaises(ConfigError, lambda: Service(name='\xe2', image='foo'))
-        self.assertRaises(ConfigError, lambda: Service(name='_', image='foo'))
-        self.assertRaises(ConfigError, lambda: Service(name='____', image='foo'))
-        self.assertRaises(ConfigError, lambda: Service(name='foo_bar', image='foo'))
-        self.assertRaises(ConfigError, lambda: Service(name='__foo_bar__', image='foo'))
 
         Service('a', image='foo')
         Service('foo', image='foo')
+        Service('foo-bar', image='foo')
+        Service('foo.bar', image='foo')
+        Service('foo_bar', image='foo')
+        Service('_', image='foo')
+        Service('___', image='foo')
+        Service('-', image='foo')
+        Service('--', image='foo')
+        Service('.__.', image='foo')
 
     def test_project_validation(self):
         self.assertRaises(ConfigError, lambda: Service('bar'))
-        self.assertRaises(ConfigError, lambda: Service(name='foo', project='_', image='foo'))
-        Service(name='foo', project='bar', image='foo')
+        self.assertRaises(ConfigError, lambda: Service(name='foo', project='>', image='foo'))
+
+        Service(name='foo', project='bar.bar__', image='foo')
 
     def test_containers(self):
         service = Service('db', self.mock_client, 'myproject', image='foo')