Browse Source

make sure the post_start hooks fails
before we were assuming the container will be close before the post_start will be executed

Signed-off-by: Guillaume Lours <[email protected]>

Guillaume Lours 5 months ago
parent
commit
f613379373
2 changed files with 3 additions and 4 deletions
  1. 2 2
      pkg/e2e/fixtures/hooks/poststart/compose-error.yaml
  2. 1 2
      pkg/e2e/hooks_test.go

+ 2 - 2
pkg/e2e/fixtures/hooks/poststart/compose-error.yaml

@@ -1,6 +1,6 @@
 services:
 
   test:
-    image: alpine
+    image: nginx
     post_start:
-      - command: sh -c 'echo env'
+      - command: sh -c 'command in error'

+ 1 - 2
pkg/e2e/hooks_test.go

@@ -33,8 +33,7 @@ func TestPostStartHookInError(t *testing.T) {
 
 	res := c.RunDockerComposeCmdNoCheck(t, "-f", "fixtures/hooks/poststart/compose-error.yaml", "--project-name", projectName, "up", "-d")
 	res.Assert(t, icmd.Expected{ExitCode: 1})
-	assert.Assert(t, strings.Contains(res.Combined(), "Error response from daemon: container"), res.Combined())
-	assert.Assert(t, strings.Contains(res.Combined(), "is not running"), res.Combined())
+	assert.Assert(t, strings.Contains(res.Combined(), "test hook exited with status 127"), res.Combined())
 }
 
 func TestPostStartHookSuccess(t *testing.T) {