notify_test.go 8.1 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445
  1. package watch
  2. import (
  3. "fmt"
  4. "io/ioutil"
  5. "os"
  6. "path/filepath"
  7. "strings"
  8. "testing"
  9. "time"
  10. "github.com/windmilleng/tilt/internal/testutils/tempdir"
  11. )
  12. // Each implementation of the notify interface should have the same basic
  13. // behavior.
  14. func TestNoEvents(t *testing.T) {
  15. f := newNotifyFixture(t)
  16. defer f.tearDown()
  17. f.assertEvents()
  18. }
  19. func TestEventOrdering(t *testing.T) {
  20. f := newNotifyFixture(t)
  21. defer f.tearDown()
  22. count := 8
  23. dirs := make([]string, count)
  24. for i, _ := range dirs {
  25. dir := f.TempDir("watched")
  26. dirs[i] = dir
  27. err := f.notify.Add(dir)
  28. if err != nil {
  29. t.Fatal(err)
  30. }
  31. }
  32. f.fsync()
  33. f.events = nil
  34. var expected []string
  35. for i, dir := range dirs {
  36. base := fmt.Sprintf("%d.txt", i)
  37. p := filepath.Join(dir, base)
  38. err := ioutil.WriteFile(p, []byte(base), os.FileMode(0777))
  39. if err != nil {
  40. t.Fatal(err)
  41. }
  42. expected = append(expected, filepath.Join(dir, base))
  43. }
  44. f.assertEvents(expected...)
  45. }
  46. func TestWatchesAreRecursive(t *testing.T) {
  47. f := newNotifyFixture(t)
  48. defer f.tearDown()
  49. root := f.TempDir("root")
  50. // add a sub directory
  51. subPath := filepath.Join(root, "sub")
  52. f.MkdirAll(subPath)
  53. // watch parent
  54. err := f.notify.Add(root)
  55. if err != nil {
  56. t.Fatal(err)
  57. }
  58. f.fsync()
  59. f.events = nil
  60. // change sub directory
  61. changeFilePath := filepath.Join(subPath, "change")
  62. _, err = os.OpenFile(changeFilePath, os.O_RDONLY|os.O_CREATE, 0666)
  63. if err != nil {
  64. t.Fatal(err)
  65. }
  66. f.assertEvents(changeFilePath)
  67. }
  68. func TestNewDirectoriesAreRecursivelyWatched(t *testing.T) {
  69. f := newNotifyFixture(t)
  70. defer f.tearDown()
  71. root := f.TempDir("root")
  72. // watch parent
  73. err := f.notify.Add(root)
  74. if err != nil {
  75. t.Fatal(err)
  76. }
  77. f.fsync()
  78. f.events = nil
  79. // add a sub directory
  80. subPath := filepath.Join(root, "sub")
  81. f.MkdirAll(subPath)
  82. // change something inside sub directory
  83. changeFilePath := filepath.Join(subPath, "change")
  84. _, err = os.OpenFile(changeFilePath, os.O_RDONLY|os.O_CREATE, 0666)
  85. if err != nil {
  86. t.Fatal(err)
  87. }
  88. f.assertEvents(subPath, changeFilePath)
  89. }
  90. func TestWatchNonExistentPath(t *testing.T) {
  91. f := newNotifyFixture(t)
  92. defer f.tearDown()
  93. root := f.TempDir("root")
  94. path := filepath.Join(root, "change")
  95. err := f.notify.Add(path)
  96. if err != nil {
  97. t.Fatal(err)
  98. }
  99. f.fsync()
  100. d1 := "hello\ngo\n"
  101. f.WriteFile(path, d1)
  102. f.assertEvents(path)
  103. }
  104. func TestWatchNonExistentPathDoesNotFireSiblingEvent(t *testing.T) {
  105. f := newNotifyFixture(t)
  106. defer f.tearDown()
  107. root := f.TempDir("root")
  108. watchedFile := filepath.Join(root, "a.txt")
  109. unwatchedSibling := filepath.Join(root, "b.txt")
  110. err := f.notify.Add(watchedFile)
  111. if err != nil {
  112. t.Fatal(err)
  113. }
  114. f.fsync()
  115. d1 := "hello\ngo\n"
  116. f.WriteFile(unwatchedSibling, d1)
  117. f.assertEvents()
  118. }
  119. func TestRemove(t *testing.T) {
  120. f := newNotifyFixture(t)
  121. defer f.tearDown()
  122. root := f.TempDir("root")
  123. path := filepath.Join(root, "change")
  124. d1 := "hello\ngo\n"
  125. f.WriteFile(path, d1)
  126. err := f.notify.Add(path)
  127. if err != nil {
  128. t.Fatal(err)
  129. }
  130. f.fsync()
  131. f.events = nil
  132. err = os.Remove(path)
  133. if err != nil {
  134. t.Fatal(err)
  135. }
  136. f.assertEvents(path)
  137. }
  138. func TestRemoveAndAddBack(t *testing.T) {
  139. f := newNotifyFixture(t)
  140. defer f.tearDown()
  141. path := filepath.Join(f.watched, "change")
  142. d1 := []byte("hello\ngo\n")
  143. err := ioutil.WriteFile(path, d1, 0644)
  144. if err != nil {
  145. t.Fatal(err)
  146. }
  147. err = f.notify.Add(path)
  148. if err != nil {
  149. t.Fatal(err)
  150. }
  151. f.assertEvents(path)
  152. err = os.Remove(path)
  153. if err != nil {
  154. t.Fatal(err)
  155. }
  156. f.assertEvents(path)
  157. f.events = nil
  158. err = ioutil.WriteFile(path, d1, 0644)
  159. if err != nil {
  160. t.Fatal(err)
  161. }
  162. f.assertEvents(path)
  163. }
  164. func TestSingleFile(t *testing.T) {
  165. f := newNotifyFixture(t)
  166. defer f.tearDown()
  167. root := f.TempDir("root")
  168. path := filepath.Join(root, "change")
  169. d1 := "hello\ngo\n"
  170. f.WriteFile(path, d1)
  171. err := f.notify.Add(path)
  172. if err != nil {
  173. t.Fatal(err)
  174. }
  175. f.fsync()
  176. d2 := []byte("hello\nworld\n")
  177. err = ioutil.WriteFile(path, d2, 0644)
  178. if err != nil {
  179. t.Fatal(err)
  180. }
  181. f.assertEvents(path)
  182. }
  183. func TestWriteBrokenLink(t *testing.T) {
  184. f := newNotifyFixture(t)
  185. defer f.tearDown()
  186. link := filepath.Join(f.watched, "brokenLink")
  187. missingFile := filepath.Join(f.watched, "missingFile")
  188. err := os.Symlink(missingFile, link)
  189. if err != nil {
  190. t.Fatal(err)
  191. }
  192. f.assertEvents(link)
  193. }
  194. func TestWriteGoodLink(t *testing.T) {
  195. f := newNotifyFixture(t)
  196. defer f.tearDown()
  197. goodFile := filepath.Join(f.watched, "goodFile")
  198. err := ioutil.WriteFile(goodFile, []byte("hello"), 0644)
  199. if err != nil {
  200. t.Fatal(err)
  201. }
  202. link := filepath.Join(f.watched, "goodFileSymlink")
  203. err = os.Symlink(goodFile, link)
  204. if err != nil {
  205. t.Fatal(err)
  206. }
  207. f.assertEvents(goodFile, link)
  208. }
  209. func TestWatchBrokenLink(t *testing.T) {
  210. f := newNotifyFixture(t)
  211. defer f.tearDown()
  212. newRoot, err := NewDir(t.Name())
  213. if err != nil {
  214. t.Fatal(err)
  215. }
  216. defer newRoot.TearDown()
  217. link := filepath.Join(newRoot.Path(), "brokenLink")
  218. missingFile := filepath.Join(newRoot.Path(), "missingFile")
  219. err = os.Symlink(missingFile, link)
  220. if err != nil {
  221. t.Fatal(err)
  222. }
  223. err = f.notify.Add(newRoot.Path())
  224. if err != nil {
  225. t.Fatal(err)
  226. }
  227. os.Remove(link)
  228. f.assertEvents(link)
  229. }
  230. func TestMoveAndReplace(t *testing.T) {
  231. f := newNotifyFixture(t)
  232. defer f.tearDown()
  233. root := f.TempDir("root")
  234. file := filepath.Join(root, "myfile")
  235. f.WriteFile(file, "hello")
  236. err := f.notify.Add(file)
  237. if err != nil {
  238. t.Fatal(err)
  239. }
  240. tmpFile := filepath.Join(root, ".myfile.swp")
  241. f.WriteFile(tmpFile, "world")
  242. err = os.Rename(tmpFile, file)
  243. if err != nil {
  244. t.Fatal(err)
  245. }
  246. f.assertEvents(file)
  247. }
  248. func TestWatchBothDirAndFile(t *testing.T) {
  249. f := newNotifyFixture(t)
  250. defer f.tearDown()
  251. dir := f.JoinPath("foo")
  252. fileA := f.JoinPath("foo", "a")
  253. fileB := f.JoinPath("foo", "b")
  254. f.WriteFile(fileA, "a")
  255. f.WriteFile(fileB, "b")
  256. f.watch(fileA)
  257. f.watch(dir)
  258. f.fsync()
  259. f.events = nil
  260. f.WriteFile(fileB, "b-new")
  261. f.assertEvents(fileB)
  262. }
  263. func TestWatchNonexistentDirectory(t *testing.T) {
  264. f := newNotifyFixture(t)
  265. defer f.tearDown()
  266. root := f.JoinPath("root")
  267. err := os.Mkdir(root, 0777)
  268. if err != nil {
  269. t.Fatal(err)
  270. }
  271. file := f.JoinPath("root", "parent", "a")
  272. f.watch(file)
  273. f.fsync()
  274. f.events = nil
  275. f.WriteFile(file, "hello")
  276. f.assertEvents(file)
  277. }
  278. type notifyFixture struct {
  279. *tempdir.TempDirFixture
  280. notify Notify
  281. watched string
  282. events []FileEvent
  283. }
  284. func newNotifyFixture(t *testing.T) *notifyFixture {
  285. SetLimitChecksEnabled(false)
  286. notify, err := NewWatcher()
  287. if err != nil {
  288. t.Fatal(err)
  289. }
  290. f := tempdir.NewTempDirFixture(t)
  291. watched := f.TempDir("watched")
  292. err = notify.Add(watched)
  293. if err != nil {
  294. t.Fatal(err)
  295. }
  296. return &notifyFixture{
  297. TempDirFixture: f,
  298. watched: watched,
  299. notify: notify,
  300. }
  301. }
  302. func (f *notifyFixture) watch(path string) {
  303. err := f.notify.Add(path)
  304. if err != nil {
  305. f.T().Fatalf("notify.Add: %s", path)
  306. }
  307. }
  308. func (f *notifyFixture) assertEvents(expected ...string) {
  309. f.fsync()
  310. if len(f.events) != len(expected) {
  311. f.T().Fatalf("Got %d events (expected %d): %v %v", len(f.events), len(expected), f.events, expected)
  312. }
  313. for i, actual := range f.events {
  314. e := FileEvent{expected[i]}
  315. if actual != e {
  316. f.T().Fatalf("Got event %v (expected %v)", actual, e)
  317. }
  318. }
  319. }
  320. func (f *notifyFixture) fsync() {
  321. syncPathBase := fmt.Sprintf("sync-%d.txt", time.Now().UnixNano())
  322. syncPath := filepath.Join(f.watched, syncPathBase)
  323. anySyncPath := filepath.Join(f.watched, "sync-")
  324. timeout := time.After(time.Second)
  325. f.WriteFile(syncPath, fmt.Sprintf("%s", time.Now()))
  326. F:
  327. for {
  328. select {
  329. case err := <-f.notify.Errors():
  330. f.T().Fatal(err)
  331. case event := <-f.notify.Events():
  332. if strings.Contains(event.Path, syncPath) {
  333. break F
  334. }
  335. if strings.Contains(event.Path, anySyncPath) {
  336. continue
  337. }
  338. // Don't bother tracking duplicate changes to the same path
  339. // for testing.
  340. if len(f.events) > 0 && f.events[len(f.events)-1].Path == event.Path {
  341. continue
  342. }
  343. f.events = append(f.events, event)
  344. case <-timeout:
  345. f.T().Fatalf("fsync: timeout")
  346. }
  347. }
  348. }
  349. func (f *notifyFixture) tearDown() {
  350. SetLimitChecksEnabled(true)
  351. err := f.notify.Close()
  352. if err != nil {
  353. f.T().Fatal(err)
  354. }
  355. f.TempDirFixture.TearDown()
  356. }