routers/repo: set raw page content type to 'text/plain' #828

README.md

@@ -13,6 +13,7 @@ Gogs(Go Git Service) is a painless self-hosted Git Service written in Go.
 
 - Due to testing purpose, data of [try.gogs.io](https://try.gogs.io) has been reset in **Jan 28, 2015** and will reset multiple times after. Please do **NOT** put your important data on the site.
 - Demo site [try.gogs.io](https://try.gogs.io) is running under `dev` branch.
+- If you think there are vulnerabilities in the project, please talk private to **[email protected]**, thanks!
 
 #### Other language version
 

conf/locale/TRANSLATORS

@@ -1,6 +1,7 @@
 # This file lists all PUBLIC individuals having contributed content to the translation.
 # Order of name is meaningless.
 
+Christoph Kisfeld <[email protected]>
 Thomas Fanninger <[email protected]>
 Łukasz Jan Niemier <[email protected]>
-Lafriks <[email protected]>
+Lafriks <[email protected]>

gogs.go

@@ -17,7 +17,7 @@ import (
 	"github.com/gogits/gogs/modules/setting"
 )
 
-const APP_VER = "0.5.12.0130 Beta"
+const APP_VER = "0.5.12.0131 Beta"
 
 func init() {
 	runtime.GOMAXPROCS(runtime.NumCPU())

routers/repo/download.go

@@ -25,16 +25,16 @@ func ServeBlob(ctx *middleware.Context, blob *git.Blob) error {
 		buf = buf[:n]
 	}
 
-	contentType, isTextFile := base.IsTextFile(buf)
+	_, isTextFile := base.IsTextFile(buf)
 	_, isImageFile := base.IsImageFile(buf)
-	ctx.Resp.Header().Set("Content-Type", contentType)
+	ctx.Resp.Header().Set("Content-Type", "text/plain")
 	if !isTextFile && !isImageFile {
 		ctx.Resp.Header().Set("Content-Disposition", "attachment; filename="+path.Base(ctx.Repo.TreeName))
 		ctx.Resp.Header().Set("Content-Transfer-Encoding", "binary")
 	}
 	ctx.Resp.Write(buf)
-	io.Copy(ctx.Resp, dataRc)
-	return nil
+	_, err = io.Copy(ctx.Resp, dataRc)
+	return err
 }
 
 func SingleDownload(ctx *middleware.Context) {

templates/.VERSION

@@ -1 +1 @@
-0.5.12.0130 Beta
+0.5.12.0131 Beta