Просмотр исходного кода

fix(cmdk): shift key state handling

Andelf 2 лет назад
Родитель
Сommit
02d97c27ba
2 измененных файлов с 4 добавлено и 4 удалено
  1. 3 4
      src/main/frontend/components/cmdk.cljs
  2. 1 0
      src/main/frontend/mixins.cljs

+ 3 - 4
src/main/frontend/components/cmdk.cljs

@@ -600,7 +600,7 @@
                                     (util/stop-propagation e))
       :else nil)))
 
-(defn keyup-handler
+(defn- keyup-handler
   [state e]
   (let [shift? (.-shiftKey e)
         meta? (.-metaKey e)
@@ -778,9 +778,8 @@
        (mixins/on-key-down state {}
                            {:target ref
                             :all-handler (fn [e _key] (keydown-handler state e))})
-       (mixins/on-key-up state {}
-                         {:target ref
-                          :all-handler (fn [e _key] (keyup-handler state e))}))))
+       (mixins/on-key-up state {} (fn [e _key]
+                                    (keyup-handler state e))))))
   (rum/local false ::shift?)
   (rum/local false ::meta?)
   (rum/local false ::alt?)

+ 1 - 0
src/main/frontend/mixins.cljs

@@ -68,6 +68,7 @@
                 nil)))))
 
 (defn on-key-up
+  "Cation: This mixin uses a different args than on-key-down"
   [state keycode-map all-handler]
   (listen state js/window "keyup"
           (fn [e]