Explorar o código

enhance(zotero): polish ui details of the zotero search component

charlie %!s(int64=2) %!d(string=hai) anos
pai
achega
1d7b6c9999

+ 9 - 3
src/main/frontend/components/svg.cljs

@@ -51,9 +51,15 @@
       :stroke          "currentColor"
       :d               d}]]))
 
-(def refresh
-  (hero-icon "M4 4V9H4.58152M19.9381 11C19.446 7.05369 16.0796 4 12 4C8.64262 4 5.76829 6.06817 4.58152 9M4.58152 9H9M20 20V15H19.4185M19.4185 15C18.2317 17.9318 15.3574 20 12 20C7.92038 20 4.55399 16.9463 4.06189 13M19.4185 15H15"
-             {:fill "none"}))
+(defn refresh
+  ([] (refresh 24 nil))
+  ([size] (refresh size nil))
+  ([size opts]
+   (hero-icon "M4 4V9H4.58152M19.9381 11C19.446 7.05369 16.0796 4 12 4C8.64262 4 5.76829 6.06817 4.58152 9M4.58152 9H9M20 20V15H19.4185M19.4185 15C18.2317 17.9318 15.3574 20 12 20C7.92038 20 4.55399 16.9463 4.06189 13M19.4185 15H15"
+              (cond-> (merge {:fill "none"} opts)
+
+                      (number? size)
+                      (assoc :height size :width size)))))
 
 (def close (hero-icon "M6 18L18 6M6 6L18 18"))
 (def folder (hero-icon "M3 7v10a2 2 0 002 2h14a2 2 0 002-2V9a2 2 0 00-2-2h-6l-2-2H5a2 2 0 00-2 2z"))

+ 131 - 126
src/main/frontend/extensions/zotero.cljs

@@ -24,28 +24,29 @@
         title (:title data)
         type (:item-type data)
         abstract (str (subs (:abstract-note data) 0 200) "...")]
-    [:div.zotero-search-item.px-2.py-4.border-b.cursor-pointer.border-solid.last:border-none.relative
+    [:div.zotero-search-item.px-2.py-2.border-b.cursor-pointer.border-solid.last:border-none.relative
      {:on-click (fn [] (go
-                        (set-is-creating-page! true)
-                        (<!
-                         (zotero-handler/create-zotero-page item {:block-dom-id id}))
-                        (set-is-creating-page! false)))}
-     [[:div [[:span.font-bold.mb-1.mr-1 title]
+                         (set-is-creating-page! true)
+                         (<!
+                           (zotero-handler/create-zotero-page item {:block-dom-id id}))
+                         (set-is-creating-page! false)))}
+     [[:div [[:span.font-medium.mb-1.mr-1.text-sm title]
              [:span.zotero-search-item-type.text-xs.p-1.rounded type]]]
-      [:div.text-sm abstract]]
+      [:div.text-sm.opacity-60 abstract]]
 
-     (when is-creating-page [:div.zotero-search-item-loading-indicator [:span.animate-spin-reverse  svg/refresh]])]))
+     (when is-creating-page
+       [:div.zotero-search-item-loading-indicator [:span.animate-spin-reverse (svg/refresh)]])]))
 
 (rum/defc zotero-search
   [id]
 
-  (let [[term set-term!]                         (rum/use-state "")
-        [search-result set-search-result!]       (rum/use-state [])
-        [prev-page set-prev-page!]               (rum/use-state "")
-        [next-page set-next-page!]               (rum/use-state "")
+  (let [[term set-term!] (rum/use-state "")
+        [search-result set-search-result!] (rum/use-state [])
+        [prev-page set-prev-page!] (rum/use-state "")
+        [next-page set-next-page!] (rum/use-state "")
         [prev-search-term set-prev-search-term!] (rum/use-state "")
-        [search-error set-search-error!]         (rum/use-state nil)
-        [is-searching set-is-searching!]         (rum/use-state false)
+        [search-error set-search-error!] (rum/use-state nil)
+        [is-searching set-is-searching!] (rum/use-state false)
 
         search-fn (fn [s-term start]
                     (go
@@ -66,55 +67,59 @@
                         (set-is-searching! false))))]
 
     (rum/use-effect!
-     (fn []
-       (let [d-chan (chan)]
-         (a/tap debounce-chan-mult d-chan)
-         (go-loop []
-           (let [d-term (<! d-chan)]
-             (<! (search-fn d-term "0")))
-           (recur))
+      (fn []
+        (let [d-chan (chan)]
+          (a/tap debounce-chan-mult d-chan)
+          (go-loop []
+                   (let [d-term (<! d-chan)]
+                     (<! (search-fn d-term "0")))
+                   (recur))
 
-         (fn [] (a/untap debounce-chan-mult d-chan))))
-     [])
+          (fn [] (a/untap debounce-chan-mult d-chan))))
+      [])
 
     (when-not (setting/valid?)
       (route-handler/redirect! {:to :zotero-setting})
       (notification/show! "Please setup Zotero API key and user/group id first!" :warn false))
 
-    [:div#zotero-search.zotero-search.p-4
-     {:style {:width 720}}
-
-     [:div.flex.items-center.mb-2
-      [[:input.p-2.border.mr-2.flex-1.focus:outline-none
-        {:autoFocus   true
-         :placeholder "Search for your Zotero journal article (title, author, text, anything)"
-         :value       term :on-change (fn [e]
-                                        (go
-                                          (>! term-chan (util/evalue e)))
-                                        (set-term! (util/evalue e)))}]
-
-       [:span.animate-spin-reverse {:style {:visibility (if is-searching "visible"  "hidden")}}  svg/refresh]]]
-
-     [:div.h-2.text-sm.text-error.mb-2 (if search-error (str "Search error: " search-error) "")]
-
-     [:div
-      (map
-       (fn [item] (rum/with-key (zotero-search-item item id) (:key item)))
-       search-result)
-      (when-not (str/blank? prev-page)
-        (ui/button
-         "prev"
-         :on-click
-         (fn []
-           (set! (.-scrollTop (.-parentNode (gdom/getElement "zotero-search"))) 0)
-           (search-fn prev-search-term prev-page))))
-      (when-not (str/blank? next-page)
-        (ui/button
-         "next"
-         :on-click
-         (fn []
-           (set! (.-scrollTop (.-parentNode (gdom/getElement "zotero-search"))) 0)
-           (search-fn prev-search-term next-page))))]]))
+    [:div#zotero-search.zotero-search
+     [:div.flex.items-center.input-wrap
+      [:input.flex-1.focus:outline-none
+       {:autoFocus   true
+        :placeholder "Search for your Zotero articles (title, author, text, anything)"
+        :value       term
+        :on-change   (fn [e]
+                       (go
+                         (>! term-chan (util/evalue e)))
+                       (set-term! (util/evalue e)))}]
+
+      (when is-searching (ui/loading ""))]
+
+     (when search-error
+       [:div.h-2.text-sm.text-error.mb-2
+        (str "Search error: " search-error "")])
+
+     (when (seq search-result)
+       [:div.p-2
+        (map
+          (fn [item] (rum/with-key (zotero-search-item item id) (:key item)))
+          search-result)
+
+        ;; pagination
+        (when-not (str/blank? prev-page)
+          (ui/button
+            "prev"
+            :on-click
+            (fn []
+              (set! (.-scrollTop (.-parentNode (gdom/getElement "zotero-search"))) 0)
+              (search-fn prev-search-term prev-page))))
+        (when-not (str/blank? next-page)
+          (ui/button
+            "next"
+            :on-click
+            (fn []
+              (set! (.-scrollTop (.-parentNode (gdom/getElement "zotero-search"))) 0)
+              (search-fn prev-search-term next-page))))])]))
 
 (rum/defcs user-or-group-setting <
   (rum/local (setting/setting :type-id) ::type-id)
@@ -150,15 +155,15 @@
         :on-change     (fn [e] (reset! (::type-id state) (util/evalue e)))}]]]]
 
    (when
-    (and (not (str/blank? (str @(::type-id state))))
-         (not (re-matches #"^\d+$" (str @(::type-id state)))))
+     (and (not (str/blank? (str @(::type-id state))))
+          (not (re-matches #"^\d+$" (str @(::type-id state)))))
      (ui/admonition
-      :warning
-      [:p.text-error
-       "User ID is different from username and can be found on the "
-       [:a {:href "https://www.zotero.org/settings/keys" :target "_blank"}
-        "https://www.zotero.org/settings/keys"]
-       " page, it's a number of digits"]))])
+       :warning
+       [:p.text-error
+        "User ID is different from username and can be found on the "
+        [:a {:href "https://www.zotero.org/settings/keys" :target "_blank"}
+         "https://www.zotero.org/settings/keys"]
+        " page, it's a number of digits"]))])
 
 (rum/defc overwrite-mode-setting <
   rum/reactive
@@ -175,9 +180,9 @@
                  true)]]]
    (when (setting/setting :overwrite-mode?)
      (ui/admonition
-      :warning
-      [:p.text-error
-       "Dangerous! This will delete and recreate Zotero existing page! Make sure to backup your notes first in case something goes wrong. Make sure you don't put any personal item in previous Zotero page and it's OK to overwrite the page!"]))])
+       :warning
+       [:p.text-error
+        "Dangerous! This will delete and recreate Zotero existing page! Make sure to backup your notes first in case something goes wrong. Make sure you don't put any personal item in previous Zotero page and it's OK to overwrite the page!"]))])
 
 (rum/defc attachment-setting <
   rum/reactive
@@ -284,7 +289,7 @@
 (rum/defc extra-tags-setting []
   [:div.row
    [:label.title
-    {:for "zotero_extra_tags"
+    {:for   "zotero_extra_tags"
      :title "Extra tags to add for every imported page. Separate by comma, or leave it empty."}
     "Extra tags to add:"]
    [:div.mt-1.sm:mt-0.sm:col-span-2
@@ -300,8 +305,8 @@
     {:for "zotero_data_directory"}
     "Zotero data directory"
     [:a.ml-2
-     {:title "Set Zotero data directory to open pdf attachment in Logseq. Click to learn more."
-      :href "https://www.zotero.org/support/zotero_data"
+     {:title  "Set Zotero data directory to open pdf attachment in Logseq. Click to learn more."
+      :href   "https://www.zotero.org/support/zotero_data"
       :target "_blank"}
      (svg/info)]]
    [:div.mt-1.sm:mt-0.sm:col-span-2
@@ -322,9 +327,9 @@
         "Please enter your profile name"]]]
 
      [:input.form-input.block.w-full.sm:text-sm.sm:leading-5.my-2
-      {:auto-focus true
+      {:auto-focus    true
        :default-value ""
-       :on-change (fn [e] (reset! input (util/evalue e)))}]
+       :on-change     (fn [e] (reset! input (util/evalue e)))}]
 
      [:div.mt-5.sm:mt-4.sm:flex.sm:flex-row-reverse
       [:span.flex.w-full.rounded-md.shadow-sm.sm:ml-3.sm:w-auto
@@ -340,7 +345,7 @@
                        (state/close-modal!))))]
       [:span.mt-3.flex.w-full.rounded-md.shadow-sm.sm:mt-0.sm:w-auto
        [:button.inline-flex.justify-center.w-full.rounded-md.border.border-gray-300.px-4.py-2.bg-white.text-base.leading-6.font-medium.text-gray-700.shadow-sm.hover:text-gray-500.focus:outline-none.focus:border-blue-300.focus:shadow-outline-blue.transition.ease-in-out.duration-150.sm:text-sm.sm:leading-5
-        {:type "button"
+        {:type     "button"
          :on-click close-fn}
         "Cancel"]]]]))
 
@@ -358,27 +363,27 @@
           (p/let [_ (setting/set-profile profile)]
             (reset! profile* profile))))}
      (map-indexed (fn [i x] [:option
-                             {:key      i
-                              :value    x}
+                             {:key   i
+                              :value x}
                              x]) (setting/all-profiles))]
     (ui/button
-     "New profile"
-     :small? true
-     :class "ml-4"
-     :on-click
-     (fn []
-       (state/set-modal!
-        (fn [close-fn]
-          (profile-name-dialog-inner profile* close-fn)))))
+      "New profile"
+      :small? true
+      :class "ml-4"
+      :on-click
+      (fn []
+        (state/set-modal!
+          (fn [close-fn]
+            (profile-name-dialog-inner profile* close-fn)))))
     (ui/button
-     "Delete profile!"
-     :small? true
-     :background "red"
-     :class "ml-4"
-     :on-click
-     (fn []
-       (p/let [_ (setting/remove-profile @profile*)]
-         (reset! profile* (setting/profile)))))]])
+      "Delete profile!"
+      :small? true
+      :background "red"
+      :class "ml-4"
+      :on-click
+      (fn []
+        (p/let [_ (setting/remove-profile @profile*)]
+          (reset! profile* (setting/profile)))))]])
 
 (rum/defcs add-all-items <
   (rum/local nil ::progress)
@@ -393,24 +398,24 @@
      "Add all zotero items"]
     [:div.mt-1.sm:mt-0.sm:col-span-2
      (ui/button
-      @(::fetching-button state)
-      :on-click
-      (fn []
-        (go
-          (let [_     (reset! (::fetching-button state) "Fetching..")
-                total (<! (api/all-top-items-count))
-                _     (reset! (::fetching-button state) "Add all")]
-            (when (.confirm
-                   js/window
-                   (str "This will import all your zotero items and add total number of " total " pages. Do you wish to continue?"))
-
-              (reset! (::total state) total)
-              (<! (zotero-handler/add-all (::progress state)))
-              (reset! (::total state) false)
-              (notification/show! "Successfully added all items!" :success))))))]]
+       @(::fetching-button state)
+       :on-click
+       (fn []
+         (go
+           (let [_ (reset! (::fetching-button state) "Fetching..")
+                 total (<! (api/all-top-items-count))
+                 _ (reset! (::fetching-button state) "Add all")]
+             (when (.confirm
+                     js/window
+                     (str "This will import all your zotero items and add total number of " total " pages. Do you wish to continue?"))
+
+               (reset! (::total state) total)
+               (<! (zotero-handler/add-all (::progress state)))
+               (reset! (::total state) false)
+               (notification/show! "Successfully added all items!" :success))))))]]
    (ui/admonition
-    :warning
-    "If you have a lot of items in Zotero, adding them all can slow down Logseq. You can type /zotero to import specific item on demand instead.")
+     :warning
+     "If you have a lot of items in Zotero, adding them all can slow down Logseq. You can type /zotero to import specific item on demand instead.")
 
    (when @(::total state)
      [:div.row
@@ -460,18 +465,18 @@
 (defn open-button [full-path]
   (if (str/ends-with? (str/lower-case full-path) "pdf")
     (ui/button
-     "open"
-     :small? true
-     :on-click
-     (fn [e]
-       (when-let [current (pdf-assets/inflate-asset full-path)]
-         (util/stop e)
-         (state/set-state! :pdf/current current))))
+      "open"
+      :small? true
+      :on-click
+      (fn [e]
+        (when-let [current (pdf-assets/inflate-asset full-path)]
+          (util/stop e)
+          (state/set-state! :pdf/current current))))
     (ui/button
-     "open"
-     :small? true
-     :target "_blank"
-     :href full-path)))
+      "open"
+      :small? true
+      :target "_blank"
+      :href full-path)))
 
 (rum/defc zotero-imported-file
   [item-key filename]
@@ -481,10 +486,10 @@
           full-path
           (str "file://"
                (util/node-path.join
-                (setting/setting :zotero-data-directory)
-                "storage"
-                item-key
-                filename))]
+                 (setting/setting :zotero-data-directory)
+                 "storage"
+                 item-key
+                 filename))]
       (open-button full-path))))
 
 (rum/defc zotero-linked-file
@@ -495,6 +500,6 @@
           full-path
           (str "file://"
                (util/node-path.join
-                (setting/setting :zotero-linked-attachment-base-directory)
-                (str/replace-first path "attachments:" "")))]
+                 (setting/setting :zotero-linked-attachment-base-directory)
+                 (str/replace-first path "attachments:" "")))]
       (open-button full-path))))

+ 28 - 4
src/main/frontend/extensions/zotero.css

@@ -8,13 +8,13 @@
   }
 
   .form-select {
-      @apply py-2;
-      min-width: 20rem;
+    @apply py-2;
+    min-width: 20rem;
   }
 
   .form-input {
-      @apply py-2;
-      min-width: 20rem;
+    @apply py-2;
+    min-width: 20rem;
   }
 
   svg {
@@ -22,6 +22,26 @@
   }
 }
 
+.zotero-search {
+  @apply w-[80vw] sm:w-[380px] lg:w-[620px];
+
+  > .input-wrap {
+    @apply relative p-2;
+
+    > input {
+      @apply p-1.5 border rounded text-sm;
+
+      color: var(--ls-primary-text-color);
+      border-color: var(--ls-secondary-border-color);
+      background-color: var(--ls-secondary-background-color);
+    }
+
+    .icon-loading {
+      @apply absolute top-4 right-4 opacity-75 scale-[.7];
+    }
+  }
+}
+
 .zotero-search-item-loading-indicator {
   position: absolute;
   top: 0;
@@ -37,6 +57,10 @@
   align-items: center;
 }
 
+.zotero-search-item {
+  border-bottom-color: var(--ls-border-color);
+}
+
 .zotero-search-item:hover {
   background-color: var(--ls-secondary-background-color);
 }

+ 1 - 1
src/main/frontend/ui.cljs

@@ -731,7 +731,7 @@
   ([] (loading (t :loading)))
   ([content] (loading content nil))
   ([content opts]
-   [:div.flex.flex-row.items-center.inline
+   [:div.flex.flex-row.items-center.inline.icon-loading
     [:span.icon.flex.items-center (svg/loader-fn opts)
      (when-not (string/blank? content)
        [:span.text.pl-2 content])]]))