Browse Source

enhance: catch UI error for development mode too

Tienson Qin 4 years ago
parent
commit
357071466a
2 changed files with 11 additions and 10 deletions
  1. 7 5
      src/main/frontend/handler.cljs
  2. 4 5
      src/main/frontend/ui.cljs

+ 7 - 5
src/main/frontend/handler.cljs

@@ -34,11 +34,13 @@
   (set! js/window.onerror
         (fn [message, source, lineno, colno, error]
           (when-not (error/ignored? message)
-            (notification/show!
-             (str "message=" message "\nsource=" source "\nlineno=" lineno "\ncolno=" colno "\nerror=" error)
-             :error
-             ;; Don't auto-hide
-             false)))))
+            (js/console.error error)
+            ;; (notification/show!
+            ;;  (str "message=" message "\nsource=" source "\nlineno=" lineno "\ncolno=" colno "\nerror=" error)
+            ;;  :error
+            ;;  ;; Don't auto-hide
+            ;;  false)
+            ))))
 
 (defn- watch-for-date!
   []

+ 4 - 5
src/main/frontend/ui.cljs

@@ -614,11 +614,10 @@
        (js/console.dir error)
        (assoc state ::error error))}
   [{error ::error, c :rum/react-component} error-view view]
-  (when error
-    (js/console.error error)
-    (log/error :ui/catch-error error))
-  (if (and (not config/dev?) (some? error))
-    error-view
+  (if (some? error)
+    (do
+      (log/error :exception error)
+      error-view)
     view))
 
 (rum/defc select