Browse Source

Add comment about allowed node version

node 17.x is the default for homebrew which doesn't work with this repo.
Make allowed node version more explicit to avoid dev confusion
Gabriel Horner 3 years ago
parent
commit
3ded9ee1ff
2 changed files with 2 additions and 1 deletions
  1. 1 0
      .github/workflows/build.yml
  2. 1 1
      README.md

+ 1 - 0
.github/workflows/build.yml

@@ -44,6 +44,7 @@ jobs:
         with:
           java-version: 1.8
 
+      # This is the latest node version of we can run
       - name: Set up Node
         uses: actions/setup-node@v2
         with:

+ 1 - 1
README.md

@@ -82,7 +82,7 @@ We also have [a dedicated page](https://github.com/logseq/logseq/blob/master/COD
 
 ### 1. Requirements
 
-- [Node.js](https://nodejs.org/en/download/) & [Yarn](https://classic.yarnpkg.com/en/docs/install/)
+- [Node.js](https://nodejs.org/en/download/) (See [build.yml](.github/workflows/build.yml) for allowed version)  & [Yarn](https://classic.yarnpkg.com/en/docs/install/)
 - [Java & Clojure](https://clojure.org/guides/getting_started). (If you run into `Execution error (FileNotFoundException) at java.io.FileInputStream/open0 (FileInputStream.java:-2). -M:cljs (No such file or directory)`, it means you have a wrong Clojure version installed. Please uninstall it and follow the instructions linked.)
 
 ### 2. Compile to JavaScript