Browse Source

fix: frontend test

remove dupe test in handler
Gabriel Horner 3 weeks ago
parent
commit
58cb27adf2
2 changed files with 21 additions and 20 deletions
  1. 0 13
      src/test/frontend/handler/reaction_test.cljs
  2. 21 7
      src/test/frontend/reaction_test.cljs

+ 0 - 13
src/test/frontend/handler/reaction_test.cljs

@@ -9,19 +9,6 @@
 
 (use-fixtures :each test-helper/start-and-destroy-db)
 
-(deftest summarize-reactions
-  (testing "groups counts and marks current user"
-    (let [user-id 1
-          reactions [{:logseq.property.reaction/emoji-id "+1"
-                      :logseq.property/created-by-ref user-id}
-                     {:logseq.property.reaction/emoji-id "+1"
-                      :logseq.property/created-by-ref 2}
-                     {:logseq.property.reaction/emoji-id "tada"}]
-          summary (reaction/summarize reactions user-id)]
-      (is (= [{:emoji-id "+1" :count 2 :reacted-by-me? true}
-              {:emoji-id "tada" :count 1 :reacted-by-me? false}]
-             summary)))))
-
 (deftest toggle-reaction-anonymous
   (testing "adds and removes reaction without user"
     (test-helper/load-test-files

+ 21 - 7
src/test/frontend/reaction_test.cljs

@@ -1,16 +1,30 @@
 (ns frontend.reaction-test
-  (:require [cljs.test :refer [deftest is testing]]
-            [frontend.reaction :as reaction]))
+  (:require [cljs.test :refer [deftest is testing use-fixtures]]
+            [frontend.reaction :as reaction]
+            [frontend.test.helper :as test-helper :refer [load-test-files]]))
+
+(use-fixtures :each {:before test-helper/start-test-db!
+                     :after test-helper/destroy-test-db!})
 
 (deftest summarize-usernames
   (testing "collects unique usernames per emoji"
-    (let [reactions [{:logseq.property.reaction/emoji-id "+1"
-                      :logseq.property/created-by-ref {:block/title "Alice"}}
+    (load-test-files
+     [{:page {:block/title "Alice"
+              :build/properties {:logseq.property.user/email "[email protected]"
+                                 :logseq.property.user/name "alice"}}}
+      {:page {:block/title "Bob"
+              :build/properties {:logseq.property.user/email "[email protected]"
+                                 :logseq.property.user/name "bob"}}}])
+    (let [alice (select-keys (test-helper/find-page-by-title "Alice") [:db/id])
+          bob (select-keys (test-helper/find-page-by-title "Bob") [:db/id])
+          reactions [{:logseq.property.reaction/emoji-id "+1"
+                      :logseq.property/created-by-ref alice}
                      {:logseq.property.reaction/emoji-id "+1"
-                      :logseq.property/created-by-ref {:logseq.property.user/name "Bob"}}
+                      :logseq.property/created-by-ref bob}
                      {:logseq.property.reaction/emoji-id "+1"
-                      :logseq.property/created-by-ref {:block/title "Alice"}}]
+                      :logseq.property/created-by-ref alice}]
           summary (reaction/summarize reactions nil)
           item (first summary)]
       (is (= "+1" (:emoji-id item)))
-      (is (= ["Alice" "Bob"] (:usernames item))))))
+      (is (= ["Alice" "Bob"] (:usernames item)))
+      (is (= 3 (:count item))))))