Przeglądaj źródła

dev: update prompts/review.md about dorun

rcmerci 4 miesięcy temu
rodzic
commit
8f6457b373
1 zmienionych plików z 2 dodań i 0 usunięć
  1. 2 0
      prompts/review.md

+ 2 - 0
prompts/review.md

@@ -7,3 +7,5 @@ You're Clojure(script) expert, you're responsible to check those common errors:
 - If the arguments of `cljs-time.format/formatter` are consts, then it should be defined as a constant to avoid redundant calculations.
 
 - Recommended to *avoid* using `memoize`, especially when the memoized function's parameters include `entity` or `block` or `conn` or `db`. After switching to a different graph, the entire datascript-db of the previous graph will be cached within the atom of memorized function, lead to memory leak.
+
+- Avoid using `dorun` to execute side effects; `doseq` is recommended.