Browse Source

enhance: display empty positioned checkbox properties

Tienson Qin 1 year ago
parent
commit
97d4a4caf6

+ 5 - 3
deps/outliner/src/logseq/outliner/property.cljs

@@ -369,9 +369,11 @@
 
 (defn- property-with-position?
   [db property-id block-properties position]
-  (and
-   (some? (get block-properties property-id))
-   (let [schema (:block/schema (d/entity db property-id))]
+  (let [property (d/entity db property-id)
+        schema (:block/schema property)]
+    (and
+     (or (some? (get block-properties property-id)) ; property value exists
+         (contains? #{:checkbox} (:type schema)))
      (= (:position schema) position))))
 
 (defn property-with-other-position?

+ 2 - 2
src/main/frontend/components/block.cljs

@@ -2421,12 +2421,12 @@
           (for [pid properties]
             (let [property (db/entity pid)
                   v (get block pid)]
-              [:div.flex.flex-row.items-center.gap-1.px-1.hover:bg-secondary.rounded
+              [:div.flex.flex-row.items-center.gap-2.px-1.hover:bg-secondary.rounded
                [:div.flex.flex-row.opacity-50.hover:opacity-100
                 (property-component/property-key-cp block property opts)
                 [:div.select-none ":"]]
                (pv/property-value block property v opts)]))]
-         [:div.positioned-properties.right-align.flex.flex-row.gap-1.select-none
+         [:div.positioned-properties.right-align.flex.flex-row.gap-2.select-none
           (for [pid properties]
             (when-let [property (db/entity pid)]
               (pv/property-value block property (get block pid) (assoc opts :show-tooltip? true))))]))))

+ 1 - 1
src/main/frontend/components/block.css

@@ -69,7 +69,7 @@
 }
 
 .block-content-or-editor-wrap {
-  @apply flex flex-1 flex-row flex-wrap gap-1;
+  @apply flex flex-1 flex-row flex-wrap gap-2;
 }
 
 .block-head-wrap {

+ 2 - 1
src/main/frontend/state.cljs

@@ -1368,7 +1368,8 @@ Similar to re-frame subscriptions"
   (clear-cursor-range!)
   (set-state! :editor/content {})
   (set-state! :ui/select-query-cache {})
-  (set-state! :editor/block-refs #{}))
+  (set-state! :editor/block-refs #{})
+  (set-state! :editor/action-data nil))
 
 (defn into-code-editor-mode!
   []