test(e2e): monitor error logs

e2e-tests/basic.spec.ts

@@ -4,9 +4,6 @@ import { randomString, createRandomPage, newBlock } from './utils'
 
 
 test('render app', async ({ page }) => {
-  // Direct Electron console to Node terminal.
-  // page.on('console', console.log)
-
   // NOTE: part of app startup tests is moved to `fixtures.ts`.
 
   expect(await page.title()).toMatch(/^Logseq.*?/)

e2e-tests/fixtures.ts

@@ -1,31 +1,47 @@
-import { test as base } from '@playwright/test';
+import { test as base, expect, ConsoleMessage } from '@playwright/test';
 import { ElectronApplication, Page, BrowserContext, _electron as electron } from 'playwright'
 
 let electronApp: ElectronApplication
 let context: BrowserContext
 let page: Page
 
+// NOTE: This is a console log watcher for error logs.
+const consoleLogWatcher = (msg: ConsoleMessage) => {
+  expect(msg.text()).not.toMatch(/^Failed to/)
+  expect(msg.text()).not.toMatch(/^Error/)
+  expect(msg.text()).not.toMatch(/^Uncaught/)
+  // NOTE: React warnings will be logged as error.
+  // expect(msg.type()).not.toBe('error')
+}
+
 base.beforeAll(async () => {
   if (electronApp) {
-    return ;
+    return
   }
 
   electronApp = await electron.launch({
     cwd: "./static",
     args: ["electron.js"],
   })
-
   context = electronApp.context()
   await context.tracing.start({ screenshots: true, snapshots: true });
 
   // NOTE: The following ensures App first start with the correct path.
-
   const appPath = await electronApp.evaluate(async ({ app }) => {
     return app.getAppPath()
   })
   console.log("Test start with AppPath:", appPath)
 
   page = await electronApp.firstWindow()
+  // Direct Electron console to watcher
+  page.on('console', consoleLogWatcher)
+  page.on('crash', () => {
+    expect('page must not crash!').toBe('page crashed')
+  })
+  page.on('pageerror', (err) => {
+    console.log(err)
+    expect('page must not have errors!').toBe('page has some error')
+  })
 
   await page.waitForLoadState('domcontentloaded')
   await page.waitForFunction('window.document.title != "Loading"')
@@ -51,8 +67,6 @@ base.afterAll(async () => {
   //}
 })
 
-
-
 // hijack electron app into the test context
 export const test = base.extend<{ page: Page, context: BrowserContext, app: ElectronApplication }>({
   page: async ({ }, use) => {