Tienson Qin 1 неделя назад
Родитель
Сommit
cb57234881

+ 1 - 0
AGENTS.md

@@ -37,3 +37,4 @@
 - DB-sync protocol reference: `docs/agent-guide/db-sync/protocol.md`.
 - New properties should be added to `logseq.db.frontend.property/built-in-properties`.
 - Avoid creating new class or property unless you have to.
+- Avoid shadow var, e.g. `bytes` should be named as `payload`.

+ 13 - 13
src/main/frontend/handler/db_based/sync.cljs

@@ -87,23 +87,23 @@
         (throw (ex-info "incomplete framed buffer" {:buffer buffer :rows rows}))))))
 
 (defn- gzip-bytes?
-  [^js bytes]
-  (and (some? bytes)
-       (>= (.-byteLength bytes) 2)
-       (= 31 (aget bytes 0))
-       (= 139 (aget bytes 1))))
+  [^js payload]
+  (and (some? payload)
+       (>= (.-byteLength payload) 2)
+       (= 31 (aget payload 0))
+       (= 139 (aget payload 1))))
 
 (defn- bytes->stream
-  [^js bytes]
+  [^js payload]
   (js/ReadableStream.
    #js {:start (fn [controller]
-                 (.enqueue controller bytes)
+                 (.enqueue controller payload)
                  (.close controller))}))
 
 (defn- <decompress-gzip-bytes
-  [^js bytes]
+  [^js payload]
   (if (exists? js/DecompressionStream)
-    (p/let [stream (bytes->stream bytes)
+    (p/let [stream (bytes->stream payload)
             decompressed (.pipeThrough stream (js/DecompressionStream. "gzip"))
             resp (js/Response. decompressed)
             buf (.arrayBuffer resp)]
@@ -114,10 +114,10 @@
 (defn- <snapshot-response-bytes
   [^js resp]
   (p/let [buf (.arrayBuffer resp)
-          bytes (->uint8 buf)]
-    (if (gzip-bytes? bytes)
-      (<decompress-gzip-bytes bytes)
-      bytes)))
+          payload (->uint8 buf)]
+    (if (gzip-bytes? payload)
+      (<decompress-gzip-bytes payload)
+      payload)))
 
 (defn- auth-headers []
   (when-let [token (state/get-auth-id-token)]

+ 3 - 3
src/test/frontend/handler/db_based/sync_test.cljs

@@ -21,17 +21,17 @@
   (let [payload (.encode test-text-encoder (sqlite-util/write-transit-str rows))]
     (frame-bytes payload)))
 
-(defn- <gzip-bytes [^js bytes]
+(defn- <gzip-bytes [^js payload]
   (if (exists? js/CompressionStream)
     (p/let [stream (js/ReadableStream.
                     #js {:start (fn [controller]
-                                  (.enqueue controller bytes)
+                                  (.enqueue controller payload)
                                   (.close controller))})
             compressed (.pipeThrough stream (js/CompressionStream. "gzip"))
             resp (js/Response. compressed)
             buf (.arrayBuffer resp)]
       (js/Uint8Array. buf))
-    (p/resolved bytes)))
+    (p/resolved payload)))
 
 (deftest remove-member-request-test
   (async done