Browse Source

fix: add GITHUB_APP2_NAME environment variable

Tienson Qin 5 years ago
parent
commit
d3dabd81de
3 changed files with 6 additions and 2 deletions
  1. 1 0
      README.md
  2. 2 1
      shadow-cljs.edn
  3. 3 1
      src/main/frontend/config.cljs

+ 1 - 0
README.md

@@ -89,6 +89,7 @@ export ENVIRONMENT="dev"
 export JWT_SECRET="xxxxxxxxxxxxxxxxxxxx"
 export COOKIE_SECRET="xxxxxxxxxxxxxxxxxxxx"
 export DATABASE_URL="postgres://localhost:5432/logseq"
+export GITHUB_APP2_NAME="logseq-test-your-username-app"
 export GITHUB_APP2_ID="78728"
 export GITHUB_APP2_KEY="xxxxxxxxxxxxxxxxxxxx" #Your Github App's Client ID
 export GITHUB_APP2_SECRET="xxxxxxxxxxxxxxxxxxxx"

+ 2 - 1
shadow-cljs.edn

@@ -18,7 +18,8 @@
                       :output-feature-set :es6
                       :externs ["datascript/externs.js"
                                 "externs.js"]}
-   :closure-defines {goog.debug.LOGGING_ENABLED true}
+   :closure-defines {goog.debug.LOGGING_ENABLED true
+                     frontend.config/GITHUB_APP_NAME #shadow/env "GITHUB_APP2_NAME"}
 
    :devtools
    ;; before live-reloading any code call this function

+ 3 - 1
src/main/frontend/config.cljs

@@ -33,7 +33,9 @@
   (if dev? path
       (str asset-domain path)))
 
-(def github-app-name (if dev? "logseq-test" "logseq"))
+(goog-define GITHUB_APP_NAME "logseq-test")
+
+(def github-app-name (if dev? GITHUB_APP_NAME "logseq"))
 
 (defn git-pull-secs
   []