fix: UI blinking when adding a :default property

src/main/frontend/components/property.cljs

@@ -182,7 +182,6 @@
                       add-class-property? (and (contains? (:block/type block) "class") page-configure? class-schema?)]
                 (p/do!
                  (when *show-new-property-config? (reset! *show-new-property-config? false))
-                 (when block (pv/exit-edit-property))
                  (when block
                    (let [id (str "ls-property-" (:db/id block) "-" (:db/id property) "-editor")]
                      (state/set-state! :editor/editing-property-value-id {id true}))
@@ -192,7 +191,8 @@
                        (pv/<create-new-block! block property ""))
                      (property-handler/set-block-property! repo (:block/uuid block)
                                                            (:db/ident (db/get-case-page property-name))
-                                                           :logseq.property/empty-placeholder))))))))}
+                                                           :logseq.property/empty-placeholder)))
+                 (when block (pv/exit-edit-property)))))))}
 
 ;; only set when in property configure modal
         (and *property-name (:type property-schema))
@@ -482,10 +482,6 @@
                              (let [add-class-property? (and (contains? (:block/type entity) "class") class-schema?)
                                    type (get-in property [:block/schema :type])]
                                (p/do!
-                                (pv/exit-edit-property)
-                                (when-not add-class-property?
-                                  (let [id (str "ls-property-" (:db/id entity) "-" (:db/id property) "-editor")]
-                                    (state/set-state! :editor/editing-property-value-id {id true})))
                                 (cond
                                   add-class-property?
                                   (pv/<add-property! entity (:db/ident property) "" {:class-schema? class-schema?
@@ -498,7 +494,11 @@
                                   (not= :default type)
                                   (property-handler/set-block-property! (state/get-current-repo) (:block/uuid entity)
                                                                         (:db/ident property)
-                                                                        :logseq.property/empty-placeholder)))))))
+                                                                        :logseq.property/empty-placeholder))
+                                (pv/exit-edit-property)
+                                (when-not add-class-property?
+                                  (let [id (str "ls-property-" (:db/id entity) "-" (:db/id property) "-editor")]
+                                    (state/set-state! :editor/editing-property-value-id {id true}))))))))
 
              input-opts {:on-blur (fn [] (pv/exit-edit-property))
                          :on-key-down

src/main/frontend/components/property/value.cljs

@@ -114,7 +114,9 @@
        (db/transact! (state/get-current-repo)
                      [[:db/retract (:db/id block) (:db/ident property) value]]
                      {:outliner-op :save-block})
-       (when-not many?
+       (when (or (not many?)
+                 ;; values will be cleared
+                 (and many? (<= (count (get block (:db/ident property))) 1)))
          (shui/popup-hide!)
          (exit-edit-property))))))
 
@@ -248,8 +250,11 @@
         f' (fn [chosen selected?]
              (if (or (and (not multiple-choices?) (= chosen clear-value))
                      (and multiple-choices? (= chosen [clear-value])))
-               (property-handler/remove-block-property! (state/get-current-repo) (:block/uuid block)
-                                                        (:db/ident property))
+               (p/do!
+                (property-handler/remove-block-property! (state/get-current-repo) (:block/uuid block)
+                                                         (:db/ident property))
+                (shui/popup-hide!)
+                (exit-edit-property))
                (f chosen selected?)))]
     (select/select (assoc opts
                           :selected-choices selected-choices