浏览代码

Resolve review comments

Mads Møller Jensen 11 月之前
父节点
当前提交
e3cfe59792
共有 3 个文件被更改,包括 8 次插入5 次删除
  1. 2 2
      book/src/list-functions-strings.md
  2. 2 2
      numbat/modules/core/strings.nbt
  3. 4 1
      numbat/modules/extra/color.nbt

+ 2 - 2
book/src/list-functions-strings.md

@@ -114,7 +114,7 @@ fn str_append(a: String, str: String) -> String
 <details>
 <summary>Examples</summary>
 
-<pre><div class="buttons"><button class="fa fa-play play-button" title="Run this code" aria-label="Run this code"  onclick=" window.open('https://numbat.dev/?q=str%5Fappend%28%22%21%22%2C%20%22Numbat%22%29')""></button></div><code class="language-nbt hljs numbat">str_append("!", "Numbat")
+<pre><div class="buttons"><button class="fa fa-play play-button" title="Run this code" aria-label="Run this code"  onclick=" window.open('https://numbat.dev/?q=%22Numbat%22%20%7C%3E%20str%5Fappend%28%22%21%22%29')""></button></div><code class="language-nbt hljs numbat">"Numbat" |> str_append("!")
 
     = "Numbat!"    [String]
 </code></pre>
@@ -131,7 +131,7 @@ fn str_prepend(a: String, str: String) -> String
 <details>
 <summary>Examples</summary>
 
-<pre><div class="buttons"><button class="fa fa-play play-button" title="Run this code" aria-label="Run this code"  onclick=" window.open('https://numbat.dev/?q=str%5Fprepend%28%22Numbat%22%2C%20%22%21%22%29')""></button></div><code class="language-nbt hljs numbat">str_prepend("Numbat", "!")
+<pre><div class="buttons"><button class="fa fa-play play-button" title="Run this code" aria-label="Run this code"  onclick=" window.open('https://numbat.dev/?q=%22%21%22%20%7C%3E%20str%5Fprepend%28%22Numbat%22%29')""></button></div><code class="language-nbt hljs numbat">"!" |> str_prepend("Numbat")
 
     = "Numbat!"    [String]
 </code></pre>

+ 2 - 2
numbat/modules/core/strings.nbt

@@ -27,11 +27,11 @@ fn lowercase(s: String) -> String
 fn uppercase(s: String) -> String
 
 @description("Concatenate two strings")
-@example("str_append(\"!\", \"Numbat\")")
+@example("\"Numbat\" |> str_append(\"!\")")
 fn str_append(a: String, str: String) -> String = "{str}{a}"
 
 @description("Concatenate two strings")
-@example("str_prepend(\"Numbat\", \"!\")")
+@example("\"!\" |> str_prepend(\"Numbat\")")
 fn str_prepend(a: String, str: String) -> String = "{a}{str}"
 
 @description("Find the first occurrence of a substring in a string")

+ 4 - 1
numbat/modules/extra/color.nbt

@@ -37,7 +37,10 @@ fn color_rgb_float(color: Color) -> String =
 @description("Convert a color to its hexadecimal representation.")
 @example("rgb(225, 36, 143) -> color_hex")
 fn color_hex(color: Color) -> String =
-  str_prepend("#", str_replace(" ", "0", str_replace("0x", "", "{color -> _color_to_scalar -> hex:>8}")))
+  "{color -> _color_to_scalar -> hex:>8}" |> 
+    str_replace("0x", "") |> 
+    str_replace(" ", "0") |> 
+    str_prepend("#")
 
 let black: Color = rgb(0, 0, 0)
 let white: Color = rgb(255, 255, 255)