Browse Source

obs-ffmpeg: Fix crash during ratecontrol check

When iterating over an array of structs we incorrectly check for a null
pointer, but the actual sentinel value is the empty struct.
Kurt Kartaltepe 2 years ago
parent
commit
0fb89dc9a1
1 changed files with 2 additions and 2 deletions
  1. 2 2
      plugins/obs-ffmpeg/obs-ffmpeg-vaapi.c

+ 2 - 2
plugins/obs-ffmpeg/obs-ffmpeg-vaapi.c

@@ -186,11 +186,11 @@ static const rc_mode_t *get_rc_mode(const char *name)
 		{.name = "CBR", .qp = false, .bitrate = true, .maxrate = false},
 		{.name = "CQP", .qp = true, .bitrate = false, .maxrate = false},
 		{.name = "VBR", .qp = false, .bitrate = true, .maxrate = true},
-		NULL};
+		{0}};
 
 	const rc_mode_t *rc_mode = RC_MODES;
 
-	while (!!rc_mode && strcmp(rc_mode->name, name) != 0)
+	while (!!rc_mode->name && strcmp(rc_mode->name, name) != 0)
 		rc_mode++;
 
 	return rc_mode ? rc_mode : RC_MODES;