UI: Create OBSPermissions on stack

This fixes the window leaking and may improve performance.

UI/obs-app.cpp

@@ -2442,10 +2442,10 @@ static int run_program(fstream &logFile, int argc, char *argv[])
 				       "MacOSPermissionsDialogLastShown");
 		if (permissionsDialogLastShown <
 		    MACOS_PERMISSIONS_DIALOG_VERSION) {
-			OBSPermissions *check = new OBSPermissions(
-				nullptr, screen_permission, video_permission,
-				audio_permission, accessibility_permission);
-			check->exec();
+			OBSPermissions check(nullptr, screen_permission,
+					     video_permission, audio_permission,
+					     accessibility_permission);
+			check.exec();
 		}
 #endif
 

UI/window-basic-main.cpp

@@ -5033,12 +5033,11 @@ void OBSBasic::on_action_Settings_triggered()
 void OBSBasic::on_actionShowMacPermissions_triggered()
 {
 #ifdef __APPLE__
-	OBSPermissions *check =
-		new OBSPermissions(this, CheckPermission(kScreenCapture),
-				   CheckPermission(kVideoDeviceAccess),
-				   CheckPermission(kAudioDeviceAccess),
-				   CheckPermission(kAccessibility));
-	check->exec();
+	OBSPermissions check(this, CheckPermission(kScreenCapture),
+			     CheckPermission(kVideoDeviceAccess),
+			     CheckPermission(kAudioDeviceAccess),
+			     CheckPermission(kAccessibility));
+	check.exec();
 #endif
 }