浏览代码

linux-capture: Fix potential null pointer dereference

Use dstr_cmp() instead of strcmp() to prevent null pointer dereferences.

This code for this source has way too many pointers.
Lain 1 年之前
父节点
当前提交
5a1fca9347
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      plugins/linux-capture/xcomposite-input.c

+ 1 - 1
plugins/linux-capture/xcomposite-input.c

@@ -310,7 +310,7 @@ xcb_window_t xcomp_find_window(xcb_connection_t *conn, Display *disp, const char
 
 		struct dstr cwname = xcomp_window_name(conn, disp, cwin);
 		struct dstr cwcls = xcomp_window_class(conn, cwin);
-		bool found = strcmp(wname, cwname.array) == 0 && strcmp(wcls, cwcls.array) == 0;
+		bool found = dstr_cmp(&cwname, wname) == 0 && dstr_cmp(&cwcls, wcls) == 0;
 
 		dstr_free(&cwname);
 		dstr_free(&cwcls);