Browse Source

frontend: Remove unnecessary projector variable

This variable is not needed, as there is a screen() function.
cg2121 1 year ago
parent
commit
708c5f7426
2 changed files with 5 additions and 11 deletions
  1. 4 8
      frontend/widgets/OBSProjector.cpp
  2. 1 3
      frontend/widgets/OBSProjector.hpp

+ 4 - 8
frontend/widgets/OBSProjector.cpp

@@ -117,15 +117,12 @@ OBSProjector::~OBSProjector()
 	}
 	}
 
 
 	App()->DecrementSleepInhibition();
 	App()->DecrementSleepInhibition();
-
-	screen = nullptr;
 }
 }
 
 
 void OBSProjector::SetMonitor(int monitor)
 void OBSProjector::SetMonitor(int monitor)
 {
 {
 	savedMonitor = monitor;
 	savedMonitor = monitor;
-	screen = QGuiApplication::screens()[monitor];
-	setGeometry(screen->geometry());
+	setGeometry(QGuiApplication::screens()[monitor]->geometry());
 	showFullScreen();
 	showFullScreen();
 	SetHideCursor();
 	SetHideCursor();
 }
 }
@@ -428,7 +425,6 @@ void OBSProjector::OpenWindowedProjector()
 
 
 	OBSSource source = GetSource();
 	OBSSource source = GetSource();
 	UpdateProjectorTitle(QT_UTF8(obs_source_get_name(source)));
 	UpdateProjectorTitle(QT_UTF8(obs_source_get_name(source)));
-	screen = nullptr;
 }
 }
 
 
 void OBSProjector::ResizeToContent()
 void OBSProjector::ResizeToContent()
@@ -486,11 +482,11 @@ void OBSProjector::SetIsAlwaysOnTop(bool isAlwaysOnTop, bool isOverridden)
 	SetAlwaysOnTop(this, isAlwaysOnTop);
 	SetAlwaysOnTop(this, isAlwaysOnTop);
 }
 }
 
 
-void OBSProjector::ScreenRemoved(QScreen *screen_)
+void OBSProjector::ScreenRemoved(QScreen *screen)
 {
 {
-	if (GetMonitor() < 0 || !screen)
+	if (GetMonitor() < 0)
 		return;
 		return;
 
 
-	if (screen == screen_)
+	if (screen == this->screen())
 		EscapeTriggered();
 		EscapeTriggered();
 }
 }

+ 1 - 3
frontend/widgets/OBSProjector.hpp

@@ -43,15 +43,13 @@ private:
 	QRect prevGeometry;
 	QRect prevGeometry;
 	void SetMonitor(int monitor);
 	void SetMonitor(int monitor);
 
 
-	QScreen *screen = nullptr;
-
 private slots:
 private slots:
 	void EscapeTriggered();
 	void EscapeTriggered();
 	void OpenFullScreenProjector();
 	void OpenFullScreenProjector();
 	void ResizeToContent();
 	void ResizeToContent();
 	void OpenWindowedProjector();
 	void OpenWindowedProjector();
 	void AlwaysOnTopToggled(bool alwaysOnTop);
 	void AlwaysOnTopToggled(bool alwaysOnTop);
-	void ScreenRemoved(QScreen *screen_);
+	void ScreenRemoved(QScreen *screen);
 	void RenameProjector(QString oldName, QString newName);
 	void RenameProjector(QString oldName, QString newName);
 
 
 public:
 public: