UI: Only emit frontend events for existing scene collection

To emit frontend events early during OBS' initialization, the
disableSaving state variable needs to be "falsy" (as events will not be
emitted otherwise).

The code path taken for generating a new fallback scene collection
has disableSaving decremented to "enable" saving (and thus frontend
events) already, so it's just the code paths for existing collections
that need this workaround.

Emitting the scene changed and preview scene changed events when a
fallback scene collection has been created has side-effects when
OBS Studio is set to studio mode and can lead to potential crashes,
as the studio mode is still in an invalid state at this point.

Co-authored-by: Ryan Foster <[email protected]>

UI/window-basic-main.cpp

@@ -2195,14 +2195,14 @@ void OBSBasic::OBSInit()
 			disableSaving++;
 		}
 
-		disableSaving--;
 		if (foundCollection || configuredCollection) {
+			disableSaving--;
 			OnEvent(OBS_FRONTEND_EVENT_SCENE_COLLECTION_LIST_CHANGED);
 			OnEvent(OBS_FRONTEND_EVENT_SCENE_COLLECTION_CHANGED);
+			OnEvent(OBS_FRONTEND_EVENT_SCENE_CHANGED);
+			OnEvent(OBS_FRONTEND_EVENT_PREVIEW_SCENE_CHANGED);
+			disableSaving++;
 		}
-		OnEvent(OBS_FRONTEND_EVENT_SCENE_CHANGED);
-		OnEvent(OBS_FRONTEND_EVENT_PREVIEW_SCENE_CHANGED);
-		disableSaving++;
 	}
 
 	loaded = true;