Bläddra i källkod

libobs: Remove various dead code found by static analysis

Detected by Coverity Scan (CID 92178, 92171)
Richard Stanway 9 år sedan
förälder
incheckning
a73b09c74e
2 ändrade filer med 3 tillägg och 12 borttagningar
  1. 2 11
      libobs/obs-service.c
  2. 1 1
      libobs/obs-source.c

+ 2 - 11
libobs/obs-service.c

@@ -53,17 +53,8 @@ static obs_service_t *obs_service_create_internal(const char *id,
 		return NULL;
 	}
 
-	if (!info) {
-		blog(LOG_ERROR, "Service ID '%s' not found", id);
-
-		service->info.id      = bstrdup(id);
-		service->owns_info_id = true;
-	} else {
-		service->info = *info;
-	}
-
-	if (info)
-		service->context.data = service->info.create(
+	service->info = *info;
+	service->context.data = service->info.create(
 				service->context.settings, service);
 	if (!service->context.data)
 		blog(LOG_ERROR, "Failed to create service '%s'!", name);

+ 1 - 1
libobs/obs-source.c

@@ -3681,7 +3681,7 @@ static inline void process_audio_source_tick(obs_source_t *source,
 void obs_source_audio_render(obs_source_t *source, uint32_t mixers,
 		size_t channels, size_t sample_rate, size_t size)
 {
-	if (!source || !source->audio_output_buf[0][0]) {
+	if (!source->audio_output_buf[0][0]) {
 		source->audio_pending = true;
 		return;
 	}