Browse Source

mac-virtualcam: Fix memory leaks

Fixes some memory leaks Xcode has detected
gxalpha 4 years ago
parent
commit
b4f940533c

+ 5 - 1
plugins/mac-virtualcam/src/dal-plugin/OBSDALPlugInInterface.mm

@@ -69,16 +69,20 @@ HRESULT HardwarePlugIn_QueryInterface(CMIOHardwarePlugInRef self, REFIID uuid,
 	CFStringRef uuidString = CFUUIDCreateString(NULL, cfUuid);
 	CFStringRef hardwarePluginUuid =
 		CFUUIDCreateString(NULL, kCMIOHardwarePlugInInterfaceID);
+	CFRelease(cfUuid);
 
 	if (CFEqual(uuidString, hardwarePluginUuid)) {
 		// Return the interface;
 		sRefCount += 1;
 		*interface = OBSDALPlugInRef();
+		CFRelease(hardwarePluginUuid);
+		CFRelease(uuidString);
 		return kCMIOHardwareNoError;
 	} else {
 		DLogFunc(@"ERR Queried for some weird UUID %@", uuidString);
 	}
-
+	CFRelease(hardwarePluginUuid);
+	CFRelease(uuidString);
 	return E_NOINTERFACE;
 }
 

+ 1 - 0
plugins/mac-virtualcam/src/dal-plugin/OBSDALStream.mm

@@ -276,6 +276,7 @@
 		pxdata, width, height, 8,
 		CVPixelBufferGetBytesPerRowOfPlane(pxbuffer, 0), rgbColorSpace,
 		kCGImageAlphaPremultipliedFirst | kCGImageByteOrder32Big);
+	CFRelease(rgbColorSpace);
 	NSParameterAssert(context);
 
 	NSGraphicsContext *nsContext = [NSGraphicsContext