Fix building on non-MSVC compilers

This function is inline, and QVariant uses a copy-on-write like copying mechanism, like most datatypes in Qt.

obs/qt-ptr-variant.hpp

@@ -26,7 +26,7 @@ struct PtrVariantDummy {
 
 Q_DECLARE_METATYPE(PtrVariantDummy*);
 
-template<typename T> static inline T VariantPtr(QVariant &v)
+template<typename T> static inline T VariantPtr(QVariant v)
 {
 	return (T)v.value<PtrVariantDummy*>();
 }

obs/window-basic-main.cpp

@@ -88,7 +88,7 @@ void OBSBasic::RemoveSceneItem(obs_sceneitem_t item)
 	obs_scene_t scene = obs_sceneitem_getscene(item);
 
 	if (GetCurrentScene() == scene) {
-		for (unsigned int i = 0; i < ui->sources->count(); i++) {
+		for (int i = 0; i < ui->sources->count(); i++) {
 			QListWidgetItem *listItem = ui->sources->item(i);
 			QVariant userData = listItem->data(Qt::UserRole);
 

obs/window-basic-main.hpp

@@ -24,9 +24,7 @@
 
 class QListWidgetItem;
 
-namespace Ui {
-	class OBSBasic;
-};
+#include "ui_OBSBasic.h"
 
 class OBSBasic : public QMainWindow {
 	Q_OBJECT

obs/window-namedialog.cpp

@@ -36,7 +36,7 @@ bool NameDialog::AskForName(QWidget *parent, const QString &title,
 
 	bool accepted = (dialog.exec() == DialogCode::Accepted);
 	if (accepted)
-		str = dialog.ui->userText->text().toUtf8();
+		str = dialog.ui->userText->text().toStdString();
 
 	return accepted;
 }

obs/window-namedialog.hpp

@@ -21,9 +21,7 @@
 #include <string>
 #include <memory>
 
-namespace Ui {
-	class NameDialog;
-};
+#include "ui_NameDialog.h"
 
 class NameDialog : public QDialog {
 	Q_OBJECT