Browse Source

decklink-output-ui: Fix crash when stopping preview

Removing the first call to `video_output_stop` prevents the `data_mutex`
field in `struct video_output` from being destroyed while still in use.
The `render_preview_source` function will call `video_output_lock_frame`
upon that mutex and encounter a NULL pointer exception.

Co-authored-by: Paul Hindt <[email protected]>
Ryan Foster 3 years ago
parent
commit
ff58d35df3
1 changed files with 0 additions and 1 deletions
  1. 0 1
      UI/frontend-plugins/decklink-output-ui/decklink-ui-main.cpp

+ 0 - 1
UI/frontend-plugins/decklink-output-ui/decklink-ui-main.cpp

@@ -124,7 +124,6 @@ void preview_output_stop()
 {
 	obs_output_stop(context.output);
 	obs_output_release(context.output);
-	video_output_stop(context.video_queue);
 
 	obs_remove_main_render_callback(render_preview_source, &context);
 	obs_frontend_remove_event_callback(on_preview_scene_changed, &context);