noise-suppress-filter.c 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553
  1. #include <stdint.h>
  2. #include <inttypes.h>
  3. #include <util/deque.h>
  4. #include <util/threading.h>
  5. #include <obs-module.h>
  6. #ifdef LIBSPEEXDSP_ENABLED
  7. #include <speex/speex_preprocess.h>
  8. #endif
  9. #ifdef LIBRNNOISE_ENABLED
  10. #ifdef _MSC_VER
  11. #define ssize_t intptr_t
  12. #endif
  13. #include <rnnoise.h>
  14. #include <media-io/audio-resampler.h>
  15. #endif
  16. /* -------------------------------------------------------- */
  17. #define do_log(level, format, ...) \
  18. blog(level, "[noise suppress: '%s'] " format, obs_source_get_name(ng->context), ##__VA_ARGS__)
  19. #define warn(format, ...) do_log(LOG_WARNING, format, ##__VA_ARGS__)
  20. #define info(format, ...) do_log(LOG_INFO, format, ##__VA_ARGS__)
  21. #ifdef _DEBUG
  22. #define debug(format, ...) do_log(LOG_DEBUG, format, ##__VA_ARGS__)
  23. #else
  24. #define debug(format, ...)
  25. #endif
  26. /* -------------------------------------------------------- */
  27. #define S_SUPPRESS_LEVEL "suppress_level"
  28. #define S_METHOD "method"
  29. #define S_METHOD_SPEEX "speex"
  30. #define S_METHOD_RNN "rnnoise"
  31. #define MT_ obs_module_text
  32. #define TEXT_SUPPRESS_LEVEL MT_("NoiseSuppress.SuppressLevel")
  33. #define TEXT_NVAFX_INTENSITY MT_("NoiseSuppress.Intensity")
  34. #define TEXT_METHOD MT_("NoiseSuppress.Method")
  35. #define TEXT_METHOD_SPEEX MT_("NoiseSuppress.Method.Speex")
  36. #define TEXT_METHOD_RNN MT_("NoiseSuppress.Method.RNNoise")
  37. #define MAX_PREPROC_CHANNELS 8
  38. /* RNNoise constants, these can't be changed */
  39. #define RNNOISE_SAMPLE_RATE 48000
  40. #define RNNOISE_FRAME_SIZE 480
  41. /* If the following constant changes, RNNoise breaks */
  42. #define BUFFER_SIZE_MSEC 10
  43. /* -------------------------------------------------------- */
  44. struct noise_suppress_data {
  45. obs_source_t *context;
  46. int suppress_level;
  47. uint64_t last_timestamp;
  48. uint64_t latency;
  49. size_t frames;
  50. size_t channels;
  51. struct deque info_buffer;
  52. struct deque input_buffers[MAX_PREPROC_CHANNELS];
  53. struct deque output_buffers[MAX_PREPROC_CHANNELS];
  54. bool use_rnnoise;
  55. bool has_mono_src;
  56. volatile bool reinit_done;
  57. #ifdef LIBSPEEXDSP_ENABLED
  58. /* Speex preprocessor state */
  59. SpeexPreprocessState *spx_states[MAX_PREPROC_CHANNELS];
  60. #endif
  61. #ifdef LIBRNNOISE_ENABLED
  62. /* RNNoise state */
  63. DenoiseState *rnn_states[MAX_PREPROC_CHANNELS];
  64. /* Resampler */
  65. audio_resampler_t *rnn_resampler;
  66. audio_resampler_t *rnn_resampler_back;
  67. #endif
  68. /* PCM buffers */
  69. float *copy_buffers[MAX_PREPROC_CHANNELS];
  70. #ifdef LIBSPEEXDSP_ENABLED
  71. spx_int16_t *spx_segment_buffers[MAX_PREPROC_CHANNELS];
  72. #endif
  73. #ifdef LIBRNNOISE_ENABLED
  74. float *rnn_segment_buffers[MAX_PREPROC_CHANNELS];
  75. #endif
  76. /* output data */
  77. struct obs_audio_data output_audio;
  78. DARRAY(float) output_data;
  79. };
  80. /* -------------------------------------------------------- */
  81. #define SUP_MIN -60
  82. #define SUP_MAX 0
  83. #ifdef LIBSPEEXDSP_ENABLED
  84. static const float c_32_to_16 = (float)INT16_MAX;
  85. static const float c_16_to_32 = ((float)INT16_MAX + 1.0f);
  86. #endif
  87. /* -------------------------------------------------------- */
  88. static const char *noise_suppress_name(void *unused)
  89. {
  90. UNUSED_PARAMETER(unused);
  91. return obs_module_text("NoiseSuppress");
  92. }
  93. static void noise_suppress_destroy(void *data)
  94. {
  95. struct noise_suppress_data *ng = data;
  96. for (size_t i = 0; i < ng->channels; i++) {
  97. #ifdef LIBSPEEXDSP_ENABLED
  98. speex_preprocess_state_destroy(ng->spx_states[i]);
  99. #endif
  100. #ifdef LIBRNNOISE_ENABLED
  101. rnnoise_destroy(ng->rnn_states[i]);
  102. #endif
  103. deque_free(&ng->input_buffers[i]);
  104. deque_free(&ng->output_buffers[i]);
  105. }
  106. #ifdef LIBSPEEXDSP_ENABLED
  107. bfree(ng->spx_segment_buffers[0]);
  108. #endif
  109. #ifdef LIBRNNOISE_ENABLED
  110. bfree(ng->rnn_segment_buffers[0]);
  111. if (ng->rnn_resampler) {
  112. audio_resampler_destroy(ng->rnn_resampler);
  113. audio_resampler_destroy(ng->rnn_resampler_back);
  114. }
  115. #endif
  116. bfree(ng->copy_buffers[0]);
  117. deque_free(&ng->info_buffer);
  118. da_free(ng->output_data);
  119. bfree(ng);
  120. }
  121. static inline void alloc_channel(struct noise_suppress_data *ng, uint32_t sample_rate, size_t channel, size_t frames)
  122. {
  123. #ifdef LIBSPEEXDSP_ENABLED
  124. ng->spx_states[channel] = speex_preprocess_state_init((int)frames, sample_rate);
  125. #else
  126. UNUSED_PARAMETER(sample_rate);
  127. #endif
  128. #ifdef LIBRNNOISE_ENABLED
  129. ng->rnn_states[channel] = rnnoise_create(NULL);
  130. #endif
  131. deque_reserve(&ng->input_buffers[channel], frames * sizeof(float));
  132. deque_reserve(&ng->output_buffers[channel], frames * sizeof(float));
  133. }
  134. static inline enum speaker_layout convert_speaker_layout(uint8_t channels)
  135. {
  136. switch (channels) {
  137. case 0:
  138. return SPEAKERS_UNKNOWN;
  139. case 1:
  140. return SPEAKERS_MONO;
  141. case 2:
  142. return SPEAKERS_STEREO;
  143. case 3:
  144. return SPEAKERS_2POINT1;
  145. case 4:
  146. return SPEAKERS_4POINT0;
  147. case 5:
  148. return SPEAKERS_4POINT1;
  149. case 6:
  150. return SPEAKERS_5POINT1;
  151. case 8:
  152. return SPEAKERS_7POINT1;
  153. default:
  154. return SPEAKERS_UNKNOWN;
  155. }
  156. }
  157. static void noise_suppress_update(void *data, obs_data_t *s)
  158. {
  159. struct noise_suppress_data *ng = data;
  160. uint32_t sample_rate = audio_output_get_sample_rate(obs_get_audio());
  161. size_t channels = audio_output_get_channels(obs_get_audio());
  162. size_t frames = (size_t)sample_rate / (1000 / BUFFER_SIZE_MSEC);
  163. const char *method = obs_data_get_string(s, S_METHOD);
  164. ng->suppress_level = (int)obs_data_get_int(s, S_SUPPRESS_LEVEL);
  165. ng->latency = 1000000000LL / (1000 / BUFFER_SIZE_MSEC);
  166. ng->use_rnnoise = strcmp(method, S_METHOD_RNN) == 0;
  167. /* Process 10 millisecond segments to keep latency low. */
  168. /* Also RNNoise only supports buffers of this exact size. */
  169. ng->frames = frames;
  170. ng->channels = channels;
  171. /* Ignore if already allocated */
  172. #if defined(LIBSPEEXDSP_ENABLED)
  173. if (!ng->use_rnnoise && ng->spx_states[0])
  174. return;
  175. #endif
  176. #ifdef LIBRNNOISE_ENABLED
  177. if (ng->use_rnnoise && ng->rnn_states[0])
  178. return;
  179. #endif
  180. /* One speex/rnnoise state for each channel (limit 2) */
  181. ng->copy_buffers[0] = bmalloc(frames * channels * sizeof(float));
  182. #ifdef LIBSPEEXDSP_ENABLED
  183. ng->spx_segment_buffers[0] = bmalloc(frames * channels * sizeof(spx_int16_t));
  184. #endif
  185. #ifdef LIBRNNOISE_ENABLED
  186. ng->rnn_segment_buffers[0] = bmalloc(RNNOISE_FRAME_SIZE * channels * sizeof(float));
  187. #endif
  188. for (size_t c = 1; c < channels; ++c) {
  189. ng->copy_buffers[c] = ng->copy_buffers[c - 1] + frames;
  190. #ifdef LIBSPEEXDSP_ENABLED
  191. ng->spx_segment_buffers[c] = ng->spx_segment_buffers[c - 1] + frames;
  192. #endif
  193. #ifdef LIBRNNOISE_ENABLED
  194. ng->rnn_segment_buffers[c] = ng->rnn_segment_buffers[c - 1] + RNNOISE_FRAME_SIZE;
  195. #endif
  196. }
  197. for (size_t i = 0; i < channels; i++)
  198. alloc_channel(ng, sample_rate, i, frames);
  199. #ifdef LIBRNNOISE_ENABLED
  200. if (sample_rate == RNNOISE_SAMPLE_RATE) {
  201. ng->rnn_resampler = NULL;
  202. ng->rnn_resampler_back = NULL;
  203. } else {
  204. struct resample_info src, dst;
  205. src.samples_per_sec = sample_rate;
  206. src.format = AUDIO_FORMAT_FLOAT_PLANAR;
  207. src.speakers = convert_speaker_layout((uint8_t)channels);
  208. dst.samples_per_sec = RNNOISE_SAMPLE_RATE;
  209. dst.format = AUDIO_FORMAT_FLOAT_PLANAR;
  210. dst.speakers = convert_speaker_layout((uint8_t)channels);
  211. ng->rnn_resampler = audio_resampler_create(&dst, &src);
  212. ng->rnn_resampler_back = audio_resampler_create(&src, &dst);
  213. }
  214. #endif
  215. }
  216. static void *noise_suppress_create(obs_data_t *settings, obs_source_t *filter)
  217. {
  218. struct noise_suppress_data *ng = bzalloc(sizeof(struct noise_suppress_data));
  219. ng->context = filter;
  220. noise_suppress_update(ng, settings);
  221. return ng;
  222. }
  223. static inline void process_speexdsp(struct noise_suppress_data *ng)
  224. {
  225. #ifdef LIBSPEEXDSP_ENABLED
  226. /* Set args */
  227. for (size_t i = 0; i < ng->channels; i++)
  228. speex_preprocess_ctl(ng->spx_states[i], SPEEX_PREPROCESS_SET_NOISE_SUPPRESS, &ng->suppress_level);
  229. /* Convert to 16bit */
  230. for (size_t i = 0; i < ng->channels; i++)
  231. for (size_t j = 0; j < ng->frames; j++) {
  232. float s = ng->copy_buffers[i][j];
  233. if (s > 1.0f)
  234. s = 1.0f;
  235. else if (s < -1.0f)
  236. s = -1.0f;
  237. ng->spx_segment_buffers[i][j] = (spx_int16_t)(s * c_32_to_16);
  238. }
  239. /* Execute */
  240. for (size_t i = 0; i < ng->channels; i++)
  241. speex_preprocess_run(ng->spx_states[i], ng->spx_segment_buffers[i]);
  242. /* Convert back to 32bit */
  243. for (size_t i = 0; i < ng->channels; i++)
  244. for (size_t j = 0; j < ng->frames; j++)
  245. ng->copy_buffers[i][j] = (float)ng->spx_segment_buffers[i][j] / c_16_to_32;
  246. #else
  247. UNUSED_PARAMETER(ng);
  248. #endif
  249. }
  250. static inline void process_rnnoise(struct noise_suppress_data *ng)
  251. {
  252. #ifdef LIBRNNOISE_ENABLED
  253. /* Adjust signal level to what RNNoise expects, resample if necessary */
  254. if (ng->rnn_resampler) {
  255. float *output[MAX_PREPROC_CHANNELS];
  256. uint32_t out_frames;
  257. uint64_t ts_offset;
  258. audio_resampler_resample(ng->rnn_resampler, (uint8_t **)output, &out_frames, &ts_offset,
  259. (const uint8_t **)ng->copy_buffers, (uint32_t)ng->frames);
  260. for (size_t i = 0; i < ng->channels; i++) {
  261. for (ssize_t j = 0, k = (ssize_t)out_frames - RNNOISE_FRAME_SIZE; j < RNNOISE_FRAME_SIZE;
  262. ++j, ++k) {
  263. if (k >= 0) {
  264. ng->rnn_segment_buffers[i][j] = output[i][k] * 32768.0f;
  265. } else {
  266. ng->rnn_segment_buffers[i][j] = 0;
  267. }
  268. }
  269. }
  270. } else {
  271. for (size_t i = 0; i < ng->channels; i++) {
  272. for (size_t j = 0; j < RNNOISE_FRAME_SIZE; ++j) {
  273. ng->rnn_segment_buffers[i][j] = ng->copy_buffers[i][j] * 32768.0f;
  274. }
  275. }
  276. }
  277. /* Execute */
  278. for (size_t i = 0; i < ng->channels; i++) {
  279. rnnoise_process_frame(ng->rnn_states[i], ng->rnn_segment_buffers[i], ng->rnn_segment_buffers[i]);
  280. }
  281. /* Revert signal level adjustment, resample back if necessary */
  282. if (ng->rnn_resampler) {
  283. float *output[MAX_PREPROC_CHANNELS];
  284. uint32_t out_frames;
  285. uint64_t ts_offset;
  286. audio_resampler_resample(ng->rnn_resampler_back, (uint8_t **)output, &out_frames, &ts_offset,
  287. (const uint8_t **)ng->rnn_segment_buffers, RNNOISE_FRAME_SIZE);
  288. for (size_t i = 0; i < ng->channels; i++) {
  289. for (ssize_t j = 0, k = (ssize_t)out_frames - ng->frames; j < (ssize_t)ng->frames; ++j, ++k) {
  290. if (k >= 0) {
  291. ng->copy_buffers[i][j] = output[i][k] / 32768.0f;
  292. } else {
  293. ng->copy_buffers[i][j] = 0;
  294. }
  295. }
  296. }
  297. } else {
  298. for (size_t i = 0; i < ng->channels; i++) {
  299. for (size_t j = 0; j < RNNOISE_FRAME_SIZE; ++j) {
  300. ng->copy_buffers[i][j] = ng->rnn_segment_buffers[i][j] / 32768.0f;
  301. }
  302. }
  303. }
  304. #else
  305. UNUSED_PARAMETER(ng);
  306. #endif
  307. }
  308. static inline void process(struct noise_suppress_data *ng)
  309. {
  310. /* Pop from input deque */
  311. for (size_t i = 0; i < ng->channels; i++)
  312. deque_pop_front(&ng->input_buffers[i], ng->copy_buffers[i], ng->frames * sizeof(float));
  313. if (ng->use_rnnoise) {
  314. process_rnnoise(ng);
  315. } else {
  316. process_speexdsp(ng);
  317. }
  318. /* Push to output deque */
  319. for (size_t i = 0; i < ng->channels; i++)
  320. deque_push_back(&ng->output_buffers[i], ng->copy_buffers[i], ng->frames * sizeof(float));
  321. }
  322. struct ng_audio_info {
  323. uint32_t frames;
  324. uint64_t timestamp;
  325. };
  326. static inline void clear_deque(struct deque *buf)
  327. {
  328. deque_pop_front(buf, NULL, buf->size);
  329. }
  330. static void reset_data(struct noise_suppress_data *ng)
  331. {
  332. for (size_t i = 0; i < ng->channels; i++) {
  333. clear_deque(&ng->input_buffers[i]);
  334. clear_deque(&ng->output_buffers[i]);
  335. }
  336. clear_deque(&ng->info_buffer);
  337. }
  338. static struct obs_audio_data *noise_suppress_filter_audio(void *data, struct obs_audio_data *audio)
  339. {
  340. struct noise_suppress_data *ng = data;
  341. struct ng_audio_info info;
  342. size_t segment_size = ng->frames * sizeof(float);
  343. size_t out_size;
  344. obs_source_t *parent = obs_filter_get_parent(ng->context);
  345. enum speaker_layout layout = obs_source_get_speaker_layout(parent);
  346. ng->has_mono_src = layout == SPEAKERS_MONO && ng->channels == 2;
  347. #ifdef LIBSPEEXDSP_ENABLED
  348. if (!ng->spx_states[0])
  349. return audio;
  350. #endif
  351. #ifdef LIBRNNOISE_ENABLED
  352. if (!ng->rnn_states[0])
  353. return audio;
  354. #endif
  355. /* -----------------------------------------------
  356. * if timestamp has dramatically changed, consider it a new stream of
  357. * audio data. clear all circular buffers to prevent old audio data
  358. * from being processed as part of the new data. */
  359. if (ng->last_timestamp) {
  360. int64_t diff = llabs((int64_t)ng->last_timestamp - (int64_t)audio->timestamp);
  361. if (diff > 1000000000LL)
  362. reset_data(ng);
  363. }
  364. ng->last_timestamp = audio->timestamp;
  365. /* -----------------------------------------------
  366. * push audio packet info (timestamp/frame count) to info deque */
  367. info.frames = audio->frames;
  368. info.timestamp = audio->timestamp;
  369. deque_push_back(&ng->info_buffer, &info, sizeof(info));
  370. /* -----------------------------------------------
  371. * push back current audio data to input deque */
  372. for (size_t i = 0; i < ng->channels; i++)
  373. deque_push_back(&ng->input_buffers[i], audio->data[i], audio->frames * sizeof(float));
  374. /* -----------------------------------------------
  375. * pop/process each 10ms segments, push back to output deque */
  376. while (ng->input_buffers[0].size >= segment_size)
  377. process(ng);
  378. /* -----------------------------------------------
  379. * peek front of info deque, check to see if we have enough to
  380. * pop the expected packet size, if not, return null */
  381. memset(&info, 0, sizeof(info));
  382. deque_peek_front(&ng->info_buffer, &info, sizeof(info));
  383. out_size = info.frames * sizeof(float);
  384. if (ng->output_buffers[0].size < out_size)
  385. return NULL;
  386. /* -----------------------------------------------
  387. * if there's enough audio data buffered in the output deque,
  388. * pop and return a packet */
  389. deque_pop_front(&ng->info_buffer, NULL, sizeof(info));
  390. da_resize(ng->output_data, out_size * ng->channels);
  391. for (size_t i = 0; i < ng->channels; i++) {
  392. ng->output_audio.data[i] = (uint8_t *)&ng->output_data.array[i * out_size];
  393. deque_pop_front(&ng->output_buffers[i], ng->output_audio.data[i], out_size);
  394. }
  395. ng->output_audio.frames = info.frames;
  396. ng->output_audio.timestamp = info.timestamp - ng->latency;
  397. return &ng->output_audio;
  398. }
  399. static bool noise_suppress_method_modified(obs_properties_t *props, obs_property_t *property, obs_data_t *settings)
  400. {
  401. obs_property_t *p_suppress_level = obs_properties_get(props, S_SUPPRESS_LEVEL);
  402. const char *method = obs_data_get_string(settings, S_METHOD);
  403. bool enable_level = strcmp(method, S_METHOD_SPEEX) == 0;
  404. obs_property_set_visible(p_suppress_level, enable_level);
  405. UNUSED_PARAMETER(property);
  406. return true;
  407. }
  408. static void noise_suppress_defaults_v1(obs_data_t *s)
  409. {
  410. obs_data_set_default_int(s, S_SUPPRESS_LEVEL, -30);
  411. #if defined(LIBRNNOISE_ENABLED) && !defined(LIBSPEEXDSP_ENABLED)
  412. obs_data_set_default_string(s, S_METHOD, S_METHOD_RNN);
  413. #else
  414. obs_data_set_default_string(s, S_METHOD, S_METHOD_SPEEX);
  415. #endif
  416. }
  417. static void noise_suppress_defaults_v2(obs_data_t *s)
  418. {
  419. obs_data_set_default_int(s, S_SUPPRESS_LEVEL, -30);
  420. #if defined(LIBRNNOISE_ENABLED)
  421. obs_data_set_default_string(s, S_METHOD, S_METHOD_RNN);
  422. #else
  423. obs_data_set_default_string(s, S_METHOD, S_METHOD_SPEEX);
  424. #endif
  425. }
  426. static obs_properties_t *noise_suppress_properties(void *data)
  427. {
  428. obs_properties_t *ppts = obs_properties_create();
  429. #ifdef LIBNVAFX_ENABLED
  430. struct noise_suppress_data *ng = (struct noise_suppress_data *)data;
  431. #else
  432. UNUSED_PARAMETER(data);
  433. #endif
  434. #if defined(LIBRNNOISE_ENABLED) && defined(LIBSPEEXDSP_ENABLED)
  435. obs_property_t *method =
  436. obs_properties_add_list(ppts, S_METHOD, TEXT_METHOD, OBS_COMBO_TYPE_LIST, OBS_COMBO_FORMAT_STRING);
  437. obs_property_list_add_string(method, TEXT_METHOD_SPEEX, S_METHOD_SPEEX);
  438. obs_property_list_add_string(method, TEXT_METHOD_RNN, S_METHOD_RNN);
  439. obs_property_set_modified_callback(method, noise_suppress_method_modified);
  440. #endif
  441. #ifdef LIBSPEEXDSP_ENABLED
  442. obs_property_t *speex_slider =
  443. obs_properties_add_int_slider(ppts, S_SUPPRESS_LEVEL, TEXT_SUPPRESS_LEVEL, SUP_MIN, SUP_MAX, 1);
  444. obs_property_int_set_suffix(speex_slider, " dB");
  445. #endif
  446. return ppts;
  447. }
  448. struct obs_source_info noise_suppress_filter = {
  449. .id = "noise_suppress_filter",
  450. .type = OBS_SOURCE_TYPE_FILTER,
  451. .output_flags = OBS_SOURCE_AUDIO | OBS_SOURCE_CAP_OBSOLETE,
  452. .get_name = noise_suppress_name,
  453. .create = noise_suppress_create,
  454. .destroy = noise_suppress_destroy,
  455. .update = noise_suppress_update,
  456. .filter_audio = noise_suppress_filter_audio,
  457. .get_defaults = noise_suppress_defaults_v1,
  458. .get_properties = noise_suppress_properties,
  459. };
  460. struct obs_source_info noise_suppress_filter_v2 = {
  461. .id = "noise_suppress_filter",
  462. .version = 2,
  463. .type = OBS_SOURCE_TYPE_FILTER,
  464. .output_flags = OBS_SOURCE_AUDIO,
  465. .get_name = noise_suppress_name,
  466. .create = noise_suppress_create,
  467. .destroy = noise_suppress_destroy,
  468. .update = noise_suppress_update,
  469. .filter_audio = noise_suppress_filter_audio,
  470. .get_defaults = noise_suppress_defaults_v2,
  471. .get_properties = noise_suppress_properties,
  472. };